[macchian]

add the topology file for Cometlake
with analog codec da7219 on SSP0 for headphone playback/headset mic
with digital codec max98357 on SSP1 for speaker playback

Signed-off-by: Mac Chiang mac.chiang@intel.com

[tlauda]

Waiting for the final code.

[macchian]

CMakeLists.txt

[jajanusz]

@macchian You requested merge to branch that is release branch. Release branch is meant to be frozen, unless you have very good reason to add something there. May I ask you why you want to do it?

[jajanusz]

@macchian Also you are missing Signed-off-by line. We require this for contributions.

[macchian]

@macchian You requested merge to branch that is release branch. Release branch is meant to be frozen, unless you have very good reason to add something there. May I ask you why you want to do it?

I'm not aware of the condition on release branch. Could you recommend the branch I should pull request? the master branch is ok?

[jajanusz]

@macchian You can add new topologies with pull request to master branch.

[ranj063]

@macchian is there a need for a new m4 file. Can we reuse sof-glk-da7219.m4 if the codec combination is the same?

[macchian]

@macchian is there a need for a new m4 file. Can we reuse sof-glk-da7219.m4 if the codec combination is the same?

I'm afraid not. Because the I2s MCLK/BCLK/LRCLK clock settings is different between glk and cml.

[ranj063]

I'm afraid not. Because the I2s MCLK/BCLK/LRCLK clock settings is different between glk and cml.

@macchian what I meant was to use the same m4 file and set these values based on the platform. Take a look at sof-cml-rt5682.m4 for example. It is the same m4 file for both cml and whl

[plbossart]

I'm afraid not. Because the I2s MCLK/BCLK/LRCLK clock settings is different between glk and cml.

@macchian what I meant was to use the same m4 file and set these values based on the platform. Take a look at sof-cml-rt5682.m4 for example. It is the same m4 file for both cml and whl

the clock tree is the same for WHL/CML. It's different for GLK/CML, so you probably need to have two m4 files.

[jajanusz]

@macchian Please change target branch. You cannot push to release branch. Probably you want to merge it to master.

[macchian]

@macchian Please change target branch. You cannot push to release branch. Probably you want to merge it to master.

Yes, I changed to mmaster branch. Please review. Thanks.

[paulstelian97]

The commits which delete and then re-add the CMakeLists file should be squashed, so as not to break git bisect (that is, there shouldn't be a commit without that file). It's also hard to see what differences are from the original one.

[jajanusz]

@ranj063 @macchian Is it the same as #1662 ? If so, please close this one.