Skip to content

topology: unify byt media pipeline params with apl media pipe - #1489

Merged
jajanusz merged 1 commit into
thesofproject:masterfrom
juimonen:byt_sched_fix
Jun 3, 2019
Merged

topology: unify byt media pipeline params with apl media pipe#1489
jajanusz merged 1 commit into
thesofproject:masterfrom
juimonen:byt_sched_fix

Conversation

@juimonen

@juimonen juimonen commented May 29, 2019

Copy link
Copy Markdown

Byt media pipeline has different parameters in topology for scheduling
deadline and frame count than apl. This produces funny 4-8x speed
playback. So unify with apl media pipe.

Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com

@juimonen
juimonen requested review from ranj063 and xiulipan as code owners May 29, 2019 11:38
This was referenced May 29, 2019
Closed
Closed
lgirdwood
lgirdwood approved these changes May 29, 2019
View reviewed changes

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juimonen can you check the other platforms for the same issue on media.

xiulipan
xiulipan suggested changes May 30, 2019
View reviewed changes

@xiulipan xiulipan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juimonen @singalsu
Please change inline comments. And who can have some explanation about why this change will fix the issue. This looks also wired to me

Comment thread tools/topology/sof-byt-codec.m4 Outdated

@xiulipan xiulipan May 30, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juimonen Please also change the comments here.

@juimonen juimonen May 31, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@juimonen

juimonen commented May 31, 2019

Copy link
Copy Markdown
Author

@xiuli yes it is weird also to me, I just want to get forward to next issue (as this will fix the 4x playback, next thing is then corrupted audio with 44.1 alternating frame count). Actually this raises questions will this happen on other platforms also if I for e.g. increase the deadline apl topology. Shouid be checked and root caused...

@xiulipan
xiulipan self-requested a review May 31, 2019 08:25
xiulipan
xiulipan approved these changes May 31, 2019
View reviewed changes

@xiulipan xiulipan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juimonen Then the patch is good to go. Could you create a issue to track why 192 frames per 4000us deadline could not work?

@tlauda

tlauda commented May 31, 2019

Copy link
Copy Markdown
Contributor

@xiulipan Could you rerun the device test?

tlauda
tlauda reviewed May 31, 2019
View reviewed changes
Comment thread tools/topology/sof-byt-codec.m4 Outdated

@tlauda tlauda May 31, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

priority 0?

@juimonen juimonen Jun 3, 2019

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, updated.

tlauda
tlauda suggested changes May 31, 2019
View reviewed changes

@tlauda tlauda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more missing change in comment.

@xiulipan

xiulipan commented May 31, 2019

Copy link
Copy Markdown
Contributor

@tlauda
Check the device test.
[INFO]: Case FAILED via PCM: HDA_Digital

It is a known issue and I will try to add blacklist for this.

@xiulipan

xiulipan commented May 31, 2019

Copy link
Copy Markdown
Contributor

@tlauda
Re run the test as we try to add HDA digit to black list now. Some HDA codec did not have digit output.

@tlauda

tlauda commented Jun 3, 2019

Copy link
Copy Markdown
Contributor

@juimonen Could you update the comment, so we could merge it?

Jaska Uimonen
topology: unify byt media pipeline params with apl media pipe
f4a5535 
Byt media pipeline has different parameters in topology for scheduling
deadline and frame count than apl. This produces funny 4-8x speed
playback. So unify with apl media pipe.

Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
@jajanusz
jajanusz merged commit 88c2ba2 into thesofproject:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes
@ranj063 ranj063 Awaiting requested review from ranj063
+3 more reviewers
@xiulipan xiulipan xiulipan approved these changes
@tlauda tlauda tlauda approved these changes
@jajanusz jajanusz jajanusz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juimonen @tlauda @xiulipan @lgirdwood @jajanusz