Repository navigation
KWD updates. - #1434
Merged
mrajwa merged 6 commits intoMay 15, 2019
Merged
KWD updates.#1434mrajwa merged 6 commits into
mrajwa merged 6 commits into
Conversation
settings We should load_mips to be 0, align values with default settings, that is: load_mips = 0, load_memory_size = 0, keyphrase_length = 0x780, activation_shift = 0x3, activation_threshold = 0x3fff. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
This patch fixes two things: - Configures HDA pipelines to be timer driven. - Moves definition of pipe-kfbm-capture to avoid overwrite of deadline and frames for other pipelines. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Add a state KPB_STATE_REALTIME for the realtime copy, and stop propagate copying while at draining. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Adds safe check to waiting functions in case we've got preempted after read, but before deadline check. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
For hw_params(), prepare(), trigger(), reset() commands, we should treat seletor as endpoint(don't propagate them upstream anymore), otherwise, those upstream components(e.g. kpb and dai) will complain about double handling and status might be wrong, errors like "source component buffer has not enough data available" will happen. This is only RFC to raise attention of this issue, it is not good fix, please help comment. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
keyonjie
requested review from
lbetlej,
lgirdwood,
mmaka1,
mrajwa,
plbossart,
ranj063 and
xiulipan
as code owners
May 15, 2019 06:28
Collaborator
|
WoV works well with this PR, but I found that there're some noise in the first 2 seconds(at draining). the reproducibility rate is about 20%. please refer to #1437 . |
This was referenced May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After applied all those 6 commits, only issue #1406 remained according to my observation.