Repository navigation
topology: fix sof-glk-da7219-kwd topology - #1430
Merged
Merged
Conversation
This patch fixes two things: - Configures HDA pipelines to be timer driven. - Moves definition of pipe-kfbm-capture to avoid overwrite of deadline and frames for other pipelines. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Contributor
Author
|
Fixes #1411. |
Contributor
|
LGTM. |
Contributor
Author
|
@xiulipan BYT failing? |
Collaborator
|
@tlauda the change is OK but moving the definition to not overwrite the frames and deadline is not the right fix because you will run in to the same problem with new topologies. The correct fix would be to undefine SCHEDULE_FRAMES and redefine it with the new value before calling the macro to create the new pipeline |
Contributor
Author
|
@ranj063 Totally agree, but both period and frames are undefined by every pipeline macro and still it doesn't work correctly. Could you point me to the right direction? |
Collaborator
Collaborator
|
Verified that this PR can fix issue #1411 . |
Contributor
Author
|
SOFCI TEST |
Contributor
|
@tlauda |
|
CI is back , good to go now. |
jajanusz
approved these changes
May 15, 2019
lgirdwood
approved these changes
May 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes two things:
of deadline and frames for other pipelines.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com