Skip to content

topology: kwd: update detector configure blob to align with default settings - #1427

Merged
tlauda merged 1 commit into
thesofproject:masterfrom
keyonjie:wov_tplg_int
May 16, 2019
Merged

topology: kwd: update detector configure blob to align with default settings#1427
tlauda merged 1 commit into
thesofproject:masterfrom
keyonjie:wov_tplg_int

Conversation

@keyonjie

@keyonjie keyonjie commented May 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Aim to fix thesofproject/linux#929

We should load_mips to be 0 as commented from @slawblauciak , Here align values with default settings, that is:

load_mips = 0, load_memory_size = 0, keyphrase_length = 0x780,
activation_shift = 0x3, activation_threshold = 0x3fff.

Signed-off-by: Keyon Jie yang.jie@linux.intel.com

@keyonjie keyonjie changed the title topology: kwd: update detector configure blob to align with default topology: kwd: update detector configure blob to align with default settings May 14, 2019
@keyonjie
topology: kwd: update detector configure blob to align with default
237ac16 
settings

We should load_mips to be 0, align values with default settings, that
is:

load_mips = 0, load_memory_size = 0, keyphrase_length = 0x780,
activation_shift = 0x3, activation_threshold = 0x3fff.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
@keyonjie

keyonjie commented May 14, 2019

Copy link
Copy Markdown
Contributor Author

this PR is used to fix:
thesofproject/linux#929

@tlauda

tlauda commented May 14, 2019

Copy link
Copy Markdown
Contributor

@keyonjie pr-device-test failed.

@keyonjie keyonjie mentioned this pull request May 14, 2019
Closed
@keyonjie

keyonjie commented May 14, 2019

Copy link
Copy Markdown
Contributor Author

@keyonjie pr-device-test failed.

That is an existed issue, not introduce by this PR?

@tlauda

tlauda commented May 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@keyonjie @xiulipan Sure, but at least we see there is something weird going on with CI. This is the first PR that has reported this problem.

@wenqingfu

wenqingfu commented May 15, 2019

Copy link
Copy Markdown

SOFCI TEST

@xiulipan

xiulipan commented May 15, 2019

Copy link
Copy Markdown
Contributor

@wenqingfu thanks for retrigger the test. I see the fail for byt_rt5651, it seems the codec is not probed through I2C. Maybe some hardware issues there, will move the problem device into maintain list and trigger again.

@xiulipan

xiulipan commented May 15, 2019

Copy link
Copy Markdown
Contributor

@keyonjie @tlauda
What do you mean here by the pr-device-test failed?

The first wrong failed build with two cases in https://sof-ci.01.org/sofpr/PR1427/build1970/
apl nocodec failed wired, not known yet why the aplay failed by failed open

[INFO]: playback checking with params [hw:0,0, 48000, 2, s16_le] ...
ALSA lib pcm_hw.c:1713:(_snd_pcm_hw_open) Invalid value for card
aplay: main:788: audio open error: No such file or directory

byt_rt5651 it seems to be hw issue, the codec is not probed by codec driver.
[ 15.772855 < 0.825764>] rt5651: probe of i2c-10EC5651:00 failed with error -121

@keyonjie keyonjie mentioned this pull request May 16, 2019
Closed
@tlauda
tlauda merged commit caa4808 into thesofproject:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrajwa mrajwa Awaiting requested review from mrajwa
@lbetlej lbetlej Awaiting requested review from lbetlej
@lgirdwood lgirdwood Awaiting requested review from lgirdwood
@mmaka1 mmaka1 Awaiting requested review from mmaka1
@plbossart plbossart Awaiting requested review from plbossart
2 more reviewers
@tlauda tlauda tlauda approved these changes
@slawblauciak slawblauciak slawblauciak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] WoV: No keyword detection before recording when runtime suspend is enabled

5 participants

@keyonjie @tlauda @wenqingfu @xiulipan @slawblauciak