Skip to content

[RFC]selector: need treat selector as endpoint for command handling #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
May 15, 2019
Merged

[RFC]selector: need treat selector as endpoint for command handling #1365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/audio/selector.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ static int selector_params(struct comp_dev *dev)
else
dev->params.channels = cd->config.in_channels_count;

return 0;
return PPL_STATUS_PATH_STOP;
}


Expand Down Expand Up @@ -303,9 +303,11 @@ static int selector_cmd(struct comp_dev *dev, int cmd, void *data,
*/
static int selector_trigger(struct comp_dev *dev, int cmd)
{
int ret;
trace_selector("selector_trigger()");

return comp_set_state(dev, cmd);
ret = comp_set_state(dev, cmd);
return ret == 0 ? PPL_STATUS_PATH_STOP : ret;
}


Expand Down Expand Up @@ -454,7 +456,7 @@ static int selector_prepare(struct comp_dev *dev)
goto err;
}

return 0;
return PPL_STATUS_PATH_STOP;

err:
comp_set_state(dev, COMP_TRIGGER_RESET);
Expand All @@ -468,9 +470,11 @@ static int selector_prepare(struct comp_dev *dev)
*/
static int selector_reset(struct comp_dev *dev)
{
int ret;
trace_selector("selector_reset()");

return comp_set_state(dev, COMP_TRIGGER_RESET);
ret = comp_set_state(dev, COMP_TRIGGER_RESET);
return ret == 0 ? PPL_STATUS_PATH_STOP : ret;
}

/**
Expand Down