Repository navigation
kpb: stop key phrase detection during draining - #1363
Merged
Merged
Conversation
lgirdwood
requested changes
May 6, 2019
tlauda
approved these changes
May 7, 2019
Contributor
|
@mrajwa please resolve conflicts |
Once draining has been started we pause copy to selector component which therefore also blocks any consecutive key phrase detection. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
Contributor
Author
|
@jajanusz, resolved. |
jajanusz
approved these changes
May 7, 2019
Contributor
Author
|
@lgirdwood, please re-review. |
Contributor
|
@lgirdwood Do you accept? |
lgirdwood
approved these changes
May 11, 2019
Member
|
@mrajwa CI build failure block merging. |
|
Hi @lgirdwood, |
Contributor
|
Looks this PR breaks KWD on my platform. @keqiaozhang also found the issue. @mrajwa can you confirm if it work on your side? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once draining has been started we pause copy to
selector component which therefore also
blocks any consecutive key phrase detection.
Signed-off-by: Marcin Rajwa marcin.rajwa@linux.intel.com