Skip to content

Kwd tplg updates - #1350

Merged
lgirdwood merged 2 commits into
thesofproject:masterfrom
keyonjie:kwd_tplg
May 9, 2019
Merged

lgirdwood merged 2 commits into
thesofproject:masterfrom
keyonjie:kwd_tplg

Conversation

@keyonjie

Copy link
Copy Markdown
Contributor

add bytes controls for both kpb and detector components.

Comment thread tools/topology/sof/pipe-kfbm-capture.m4 Resolved
Comment thread tools/topology/m4/detect_coef.m4 Resolved
@keyonjie

keyonjie commented May 5, 2019

Copy link
Copy Markdown
Contributor Author

@lgirdwood updated, please help review.

@keyonjie

keyonjie commented May 7, 2019

Copy link
Copy Markdown
Contributor Author

Hi @mrajwa @tlauda can you help review this please, we need at least one more approval before this can be merged.

mrajwa
mrajwa previously requested changes May 7, 2019
Comment thread tools/topology/m4/kpbm.m4 Resolved
Comment thread tools/topology/sof/pipe-kfbm-capture.m4 Resolved
Comment thread tools/topology/sof/pipe-kfbm-capture.m4 Resolved
Comment thread tools/topology/sof/pipe-detect.m4 Resolved
@keyonjie

keyonjie commented May 8, 2019

Copy link
Copy Markdown
Contributor Author

comments addressed, @tlauda @mrajwa

@keyonjie
keyonjie requested review from mrajwa and tlauda May 8, 2019 00:57
keyonjie added 2 commits May 8, 2019 09:00
We design to use bytes kcontrol to send kpb configuration data via IPC
from topology, here implement it.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Add bytes control and initial value for detector component.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
@tlauda

tlauda commented May 8, 2019

Copy link
Copy Markdown
Contributor

@zrombel Could we rerun the CI?

@keyonjie

keyonjie commented May 9, 2019

Copy link
Copy Markdown
Contributor Author

looks the CI fail to work, @zrombel?

@keyonjie

keyonjie commented May 9, 2019

Copy link
Copy Markdown
Contributor Author

@tlauda @lgirdwood could either of you help to merge this if no more changes needed, then it can go to validation soon.

@tlauda

tlauda commented May 9, 2019

Copy link
Copy Markdown
Contributor

@mrajwa Do you accept the changes?

@lgirdwood
lgirdwood dismissed mrajwa’s stale review May 9, 2019 21:25

no comment on latest changes

@lgirdwood
lgirdwood merged commit 030c81c into thesofproject:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants