Skip to content

[RFC]platform:bug fix: alsa xrun cause fw panic. #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

[RFC]platform:bug fix: alsa xrun cause fw panic. #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/ipc/handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,18 @@ static int ipc_stream_trigger(uint32_t header)
return 0;
}

/* when START command comes, the pipeline has to be prepared.
* This case has to be taken into account:
* when ALSA has XRUN, it will send stop/start commands to FW
* and try to recover the pipepine. If we did not prepare
* the pipeline before start, the recover process will fail.
*/
if (cmd == COMP_TRIGGER_START) {
ret = pipeline_prepare(pcm_dev->cd->pipeline, pcm_dev->cd);
if (ret < 0)
trace_ipc_error("eR1");
}

/* trigger the component */
ret = pipeline_trigger(pcm_dev->cd->pipeline, pcm_dev->cd, cmd);
if (ret < 0) {
Expand Down