Skip to content

dw-dma: cleanup the whole driver - #1273

Merged
lgirdwood merged 4 commits into
thesofproject:masterfrom
tlauda:topic/dw-dma-refactor
Apr 18, 2019
Merged

lgirdwood merged 4 commits into
thesofproject:masterfrom
tlauda:topic/dw-dma-refactor

Conversation

@tlauda

@tlauda tlauda commented Apr 16, 2019

Copy link
Copy Markdown
Contributor

Cleanups the whole DW-DMA driver:

  • Move platform register defines to proper headers.
  • Make driver independent of platform.
  • Use the same accepted style of trace logs.
  • Other minor tweaks.

Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com

tlauda added 4 commits April 16, 2019 15:47
Removes unused conditional code from DW-DMA
driver.

Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Makes DW-DMA stop method to be configurable from Kconfig.
Some of the platforms cannot stop DMA channel immediately,
but first need to suspend and drain FIFO.

Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Makes DMA FIFO partitioning configurable from Kconfig.
Some platforms need to set FIFO partitions before
enabling DMA controller.

Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Cleanups the whole DW-DMA driver:
- Move platform register defines to proper headers.
- Make driver independent of platform.
- Use the same accepted style of trace logs.
- Other minor tweaks.

Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keqiaozhang can you test on BYT

@Jiangxinx

Copy link
Copy Markdown
Contributor

@lgirdwood @keqiaozhang I have tested base function with this patch on BYT rt5651 platform, didn't find any regressions.

@lgirdwood

Copy link
Copy Markdown
Member

@mmaka1 @jajanusz can you guys review so we can merge.

@lgirdwood
lgirdwood merged commit e2b994e into thesofproject:master Apr 18, 2019
@tlauda
tlauda deleted the topic/dw-dma-refactor branch November 22, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants