Repository navigation
Conversation
set SOF_RIMAGE_KEY in cmake cmd or as an ENV variable will override the cmake configure to a specific key. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
|
@plbossart The SOF_RIMAGE_KEY will be accept as CMake option or ENV. The ENV will override the CMake option. Will have another PR to override the rimage itself to accept the key from ENV. CMake config part for #1238 |
jajanusz
left a comment
jajanusz
left a comment
There was a problem hiding this comment.
Idea is good and feature is needed, I just have minor concerns regarding conventions
| USES_TERMINAL | ||
| ) | ||
| else() | ||
| if(NOT DEFINED ENV{SOF_RIMAGE_KEY}) |
There was a problem hiding this comment.
Please don't use env variables. I know they may look handy but it makes harder to figure out what comes from where. Also other params are not settable this way, so if we decide to support env variables we would have to do it for all variables for consistency.
| ) | ||
| else() | ||
| if(NOT DEFINED ENV{SOF_RIMAGE_KEY}) | ||
| if(NOT DEFINED SOF_RIMAGE_KEY) |
There was a problem hiding this comment.
I think it should be just RIMAGE_KEY, other variables are named without SOF_ prefix
|
@jajanusz I would like to merge RIMAGE_KEY with the MEU_KEY as a SIGNING_KEY |
|
@xiulipan I don't know if these 2 values should be merged, is there some use case when you would use 1 key for rimage and another for meu? |
2 participants
set SOF_RIMAGE_KEY in cmake cmd or as an ENV variable will override the
cmake configure to a specific key.
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com