Repository navigation
host: fix playback with DW-DMA - #1162
Merged
Merged
Conversation
Fixes playback with DW-DMA. Flow of pipeline copy has changed, so now we need to preload the whole buffer before allowing first copy to further components. Also we need to move dma_copy call to buffer callbacks to be up to date with data. This was previosly done only for Host DMA. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
March 21, 2019 12:03
This was referenced Mar 21, 2019
lgirdwood
approved these changes
Mar 21, 2019
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
We really need to move the whole conditional logic out of host.c and into DMA drivers via extended ops. This should be done soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes playback with DW-DMA. Flow of pipeline copy
has changed, so now we need to preload the whole
buffer before allowing first copy to further
components. Also we need to move dma_copy call
to buffer callbacks to be up to date with data.
This was previosly done only for Host DMA.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com