Repository navigation
Volume: Improve PCM format handling in params and prepare - #1136
Merged
lgirdwood merged 1 commit intoMar 21, 2019
Merged
Conversation
This patch removes from params function the setting of component's own stored frame_fmt since the variable cd->sink_format was not set. In prepare function the frame_fmt is stored based on stream direction. In playback it's set from source and in capture from sink. This way the format matches the host component side of stream. These changes help other components in the pipeline to operate with correct PCM format. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
volume_improve_formats_handling
branch
from
March 15, 2019 14:11
f2acf1e to
c07ee51
Compare
Collaborator
Author
|
Update: I fixed commit text. |
ranj063
reviewed
Mar 15, 2019
ranj063
approved these changes
Mar 15, 2019
lgirdwood
approved these changes
Mar 15, 2019
Member
|
Still pending on some CI |
Collaborator
Author
|
@tlauda Thanks for suggesting this fix! |
|
@lgirdwood @mmaka1 CI is complete, two approvals, good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes from params function the setting of component's
own stored frame_fmt since the variable cd->sink_format was not set.
In prepare function the stored frame_fmt is stored based on stream
direction. In playback it's set from source and in capture from sink.
This way the format matches the host component.
These changes help other components in the pipeline to operate with
correct PCM format.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com