Repository navigation
module: tdfb: rework module to use sink/source api - #11297
Open
softwarecki wants to merge 3 commits into
Open
softwarecki wants to merge 3 commits into
softwarecki wants to merge 3 commits into
Conversation
softwarecki
requested review from
abonislawski,
serhiy-katsyuba-intel,
tmleman and
wjablon1
and
a balanced review from Copilot
October 12, 2026 21:34
softwarecki
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
singalsu
as code owners
October 12, 2026 21:34
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The delay-size error contract and configured frame-alignment handling are currently broken.
2 open findings
What changed in this PR
Migrates TDFB processing to the sink/source API for pipeline 2.0 readiness.
Changes:
- Reworks TDFB buffering and processing around circular source/sink views.
- Updates generic and optimized FIR implementations to the new interfaces.
- Adjusts related size and channel-count types.
| File | Description |
|---|---|
src/math/iir_df1.c |
Changes delay-size return type. |
src/include/sof/math/iir_df1.h |
Updates the public declaration. |
src/audio/tdfb/tdfb.c |
Migrates core processing and preparation. |
src/audio/tdfb/tdfb_ipc4.c |
Updates IPC4 source/sink formats. |
src/audio/tdfb/tdfb_ipc3.c |
Updates parameter signature. |
src/audio/tdfb/tdfb_hifiep.c |
Migrates HiFi2EP processing. |
src/audio/tdfb/tdfb_hifi3.c |
Migrates HiFi3 processing. |
src/audio/tdfb/tdfb_generic.c |
Migrates generic processing. |
src/audio/tdfb/tdfb_direction.c |
Updates frame and channel types. |
src/audio/tdfb/tdfb_comp.h |
Updates TDFB interfaces and state. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
PR 11297: test resultsRun date: 2026-10-12 22:05 UTC Tested commit: 9c62482b0fd31c87b81d46c5e97ccd36e5b060fa
|
serhiy-katsyuba-intel
approved these changes
Oct 13, 2026
Member
|
@softwarecki think its good to merge once copilot is resolved. |
lgirdwood
approved these changes
Oct 13, 2026
Member
|
@softwarecki just one issue |
Change iir_delay_size_df1() to return size_t and report 0 on an invalid configuration instead of a negative value. Document that a 0 return signals an error, and add the missing return-value checks where callers did not handle that failure. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Rework the tdfb module to only use the sink/source api to prepare sof for the full transition to pipeline 2.0. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Use unsigned int for channel counts and size_t for frame, sample counts and buffer size. Change the IIR delay-size helper to return size_t. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
force-pushed
the
p20-tdfb
branch
2 times, most recently
from
October 13, 2026 14:39
1c2b295 to
461a293
Compare
lgirdwood
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the tdfb audio module to only use the sink/source api to prepare sof for the full transition to pipeline 2.0.