Repository navigation
pipeline: dai: dw-dma: adjust flow to more scheduler flexible - #1125
Conversation
Adjusts pipeline flow to be more scheduler flexible and not only valid for DMA IRQ based schedulers. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
|
|
||
| return ret; | ||
| /* let's not copy further */ | ||
| return 1; |
There was a problem hiding this comment.
Just wondering (for a future PR), do we want to define a macro for PIPELINE_COPY_FURTHER_STOP to make it obvious for anyone reading the 1 here.
There was a problem hiding this comment.
Yes, I was thinking about that and it would also be helpful for things like prepare, so probably I will make a PR with something like PIPELINE_OPERATION_FURTHER_STOP.
| if (dir == PPL_DIR_DOWNSTREAM) { | ||
| err = comp_copy(current); | ||
| if (err < 0) | ||
| if (err < 0 || err > 0) |
There was a problem hiding this comment.
if (err > 0 ) then it's copy stop (which is not an error). So we probably want to change this to 0 ?
There was a problem hiding this comment.
For other operations like params and prepare it's not modified back to 0, so I wanted to stay aligned. Anyway maybe some higher level function will need to know this status in the future and that it was stopped intentionally.
|
@lgirdwood @xiulipan Travis didn't start for this PR. Who can retrigger it? |
|
@tlauda Travis may have been down for a while as this PR is not in it's queue (otherwise I can restart). PR's before and after are in the queue. A force push will fix it. |
Adjusts dai and dw-dma configuration flows to be more scheduler flexible and not only working for DMA IRQ based schedulers. Note: due to the nature of timer scheduling we need to have restriction for dw-dma to support minimum 3 linked list items. Without such restriction we may not be able to clear done bits on time. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
2a38280 to
649f00e
Compare
|
@lgirdwood CI passed, ready to be merged. |
Adjusts pipeline, dai and dw-dma flows to be more scheduler flexible
and not only valid for DMA IRQ based schedulers.