Repository navigation
dw-dma: enable interrupts based on the scheduling mode - #1116
Merged
Merged
Conversation
Adds simple method to check if pipeline is scheduled with timer or not. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
requested review from
bardliao,
lbetlej,
lgirdwood,
lyakh,
mmaka1,
plbossart and
xiulipan
as code owners
March 12, 2019 12:46
tlauda
force-pushed
the
topic/dw-dma-irq-enabled
branch
from
March 12, 2019 12:47
912b576 to
b0c09af
Compare
tlauda
changed the title
lyakh
requested changes
Mar 12, 2019
Collaborator
|
@tlauda is timer-based scheduling actually already available? I don't see any uses of |
Contributor
Author
|
@lyakh Not yet, working towards it. |
tlauda
force-pushed
the
topic/dw-dma-irq-enabled
branch
2 times, most recently
from
March 12, 2019 14:51
65586ec to
3ff3394
Compare
Adds new functionality to DW-DMA driver to enable/disable interrupts based on the pipeline scheduling mode. If we are scheduling on timer there is no need to touch any irq related registers. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
force-pushed
the
topic/dw-dma-irq-enabled
branch
from
March 13, 2019 08:16
3ff3394 to
1f6e469
Compare
lgirdwood
approved these changes
Mar 13, 2019
Member
|
@tlauda we should also hard code irq_disabled = true for HDA-DMA with a comment to make it obvious to anyone that its not supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new functionality to DW-DMA driver to enable/disable
interrupts based on the pipeline scheduling mode. If
we are scheduling on timer there is no need to touch
any irq related registers.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com