Repository navigation
SRC: Add attenuation of -1 dB into processing to avoid saturation - #1069
Merged
lgirdwood merged 1 commit intoMar 4, 2019
Merged
Conversation
This patch replaces all the filter coefficients to avoid the unpleasant effect of samples saturation that the previous 0 dB max. gain scaled coefficients could cause. The saturation of transients may still happen but it should be more rare. The filter coefficients scaling is changed from fixed pass band peak align (to 0 dB) into DC gain controllable via new parameter gain in src_param.m. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Collaborator
Author
|
This addresses issue #619 though I could find no overflow to happen in firmware. The change for SRC tools is in the end of the diff listing. |
lgirdwood
approved these changes
Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces all the filter coefficients to avoid the
unpleasant effect of samples saturation that the previous 0 dB max.
gain scaled coefficients could cause. The saturation of transients
may still happen but it should be more rare.
The filter coefficients scaling is changed from fixed pass band peak
align (to 0 dB) into DC gain controllable via new parameter gain in
src_param.m.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com