Repository navigation
Conversation
There was a problem hiding this comment.
I guess we need some SOF_COMP_DEFAULT_FLAVOR enum value that will be a default for other components.
There was a problem hiding this comment.
what exactly is stored in num_elements when for cmd == SOF_CMD_ENUM ? is it a number of parameters and each chanv[j].value represents enum value of parameter[0..num_elements] ?
There was a problem hiding this comment.
its the number of channel elements to be changed.
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
not completely clear on some parts, see below
There was a problem hiding this comment.
what does 2 refer to? two channels? two outputs?
There was a problem hiding this comment.
@plbossart this should be changed sorry to the max channels supported.
This will be a general purpose mux. Add the init/free and cmd op to support passing enum values to the mux comp. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
|
@lgirdwood @plbossart updated now. I will add the subtype bits in ww9 |
|
@plbossart any comments on the update ? |
|
@ranj063 Is this change still valid? |
|
@lgirdwood @ranj063 It seems that @akloniex has done the full implementation in #1275. Should we close this one? |
This will be a general purpose mux. Add the init/free
and cmd op to support passing enum values to the mux
comp.
Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com