Repository navigation
CTX_SAVE ipc failure during runtime suspend #984
Description
The CTX_SAVE ipc seems to fail always before the system enters runtime suspend:
kernel: https://github.com/ranj063/linux/tree/cros-sof-v4.19-ww05
fw: master ebf4f4b
topology: sof-cml-rt5682 (with PR #976)
Will post sof-logger trace soon.
dmesg logs:
[ 41.384293] sof-audio-pci 0000:00:1f.3: ipc rx done: 0x90020000
[ 42.739631] sof-audio-pci 0000:00:1f.3: ipc tx: 0x40010000
[ 42.740056] sof-audio-pci 0000:00:1f.3: error: ipc error for 0x40010000 size 0xc
[ 42.740094] sof-audio-pci 0000:00:1f.3: error: ctx_save ipc error during suspend -1
[ 42.740164] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0x1010f0f successful
[ 42.741247] sof-audio-pci 0000:00:1f.3: FW Poll Status: reg=0xf0f successful
[ 42.741269] sof-audio-pci 0000:00:1f.3: DSP core(s) enabled? 0 : core_mask f
[ 42.741455] sof-audio-pci 0000:00:1f.3: Debug PCIR: 00000010 at 00000044
Activity
lgirdwood commentedon Feb 8, 2019
@lbetlej fyi, I assume this is calling the PM IPC reply assembly code ?
lbetlej commentedon Feb 13, 2019
@ranj063 the fw: master [ebf4f4b] includes PR#962 (@akloniex) and was verified by @emilchudzik , could you confirm that driver is not accessing memory window on CTX_SAVE reply ?
lgirdwood commentedon Feb 13, 2019
@ranj063 it's probably worth addig a BUG() macro in platform ops for mailbox read/write() if DSP is in D3. This way we catch out any abusers.
ranj063 commentedon Feb 13, 2019
@lbetlej @lgirdwood yes we are accessing the CTX_SAVE reply indeed. @bardliao will be covering for me for CML. Bard, could you please take a look at this?
ranj063 commentedon Feb 15, 2019
@lgirdwood @lbetlej out of curiosity. Whats different in the D3 flow in CNL that causes in problem? I ask because we dont seem to have this problem on GLK
mengdonglin commentedon Feb 25, 2019
Kernel PR thesofproject/linux#651 is to fix this issue.
emilchudzik commentedon Feb 25, 2019
Agree. Verified on:
Platform: WHL RVP
kernel: cros-sof-v4.19 / 8492020d5967 + PR#651 applied
FW: cml-002-drop-stable / dcd825b
tplg for hda: sof-hda-generic.tplg