[BUG] SOF fails to load on MTL (with Linux 6.8 or older driver)

SOF firmware built from HEAD isn't loading for us on MTL since the last Zephyr west.yml update. The symptom is that it hangs on load with a complaint in early load about the rom_status_reg not showing an update:

[   46.688586] sof-audio-pci-intel-mtl 0000:00:1f.3: hda_cl_copy_fw: timeout with rom_status_reg (0x180000) read
[   46.688606] sof-audio-pci-intel-mtl 0000:00:1f.3: ------------[ DSP dump start ]------------
[   46.688611] sof-audio-pci-intel-mtl 0000:00:1f.3: Firmware download failed
[   46.688615] sof-audio-pci-intel-mtl 0000:00:1f.3: fw_state: SOF_FW_BOOT_READY_OK (6)
[   46.688628] sof-audio-pci-intel-mtl 0000:00:1f.3: ROM status: 0x0, ROM error: 0x0
[   46.688632] sof-audio-pci-intel-mtl 0000:00:1f.3: ROM debug status: 0x50000005, ROM debug error: 0x0
[   46.688642] sof-audio-pci-intel-mtl 0000:00:1f.3: ROM feature bit not enabled
[   46.688646] sof-audio-pci-intel-mtl 0000:00:1f.3: ------------[ DSP dump end ]------------
[   46.688665] sof-audio-pci-intel-mtl 0000:00:1f.3: Failed to start DSP
[   46.688669] sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed to boot DSP firmware -110
[   46.690414] sof-audio-pci-intel-mtl 0000:00:1f.3: error: sof_probe_work failed err: -110

The culprit is this Zephyr commit from a few weeks back, which claims that it's disabled the FW_STATUS output deliberately because it's not needed on ACE 1.x:

zephyrproject-rtos/zephyr@fa798ce

commit fa798ce2d5be6deb8a3b0cde307a0a1dc5e88dde
Author: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Date:   Thu May 23 12:09:05 2024 +0300

    soc: intel_adsp: only implement FW_STATUS boot protocol for cavs

    The software protocol to write status value of 0x05 (FW_ENTERED)
    into memory window 0 at Zephyr boot, is not needed in the ace1.x
    boot flow and does not match the semantics host systems are expecting
    at this location in the memory window (e.g. write of 0x05 is not
    expected).

    Make this logic specific to intel_adsp_cavs platforms and move the code
    out from common intel_adsp code.

    This commit depends on update to cavstool.py to use correct
    ROM status register to observe boot state.

    Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>

Nonetheless, the kernel seems to still care. The timeout in question is in hda-loader.c: https://github.com/thesofproject/linux/blob/topic/sof-dev/sound/soc/sof/intel/hda-loader.c#L293 and it's quite clearly still polling this address.

Reverting just that one patch from the Zephyr module fixes load for us.

Not sure why this isn't being hit upstream? Is there another MTL loader path that should be hit instead, maybe due to something skewed in our kernel. That link is to the topic/sof-dev branch and matches the ChromeOS kernels and upstream, so it's not as simple as a missing update to this code.

Revert "soc: intel_adsp: only implement FW_STATUS boot protocol for c…

Zephyr PR with the relevant cherry pick, just to be clear about things: zephyrproject-rtos/zephyr#74552

@andyross

@andyross Kernel has stopped looking at the memory window location since this patch:

commit 1f1b820dc3c65b6883da3130ba3b8624dcbf87db
Author: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Date:   Wed Apr 3 13:52:05 2024 +0300

    ASoC: SOF: Intel: mtl: Correct rom_status_reg

This has a fixes tag, so should show up in all stable series that in general have MTL support (e.g. 6.9.3 has it already).

This is still a miss, we probably need the Zephyr revert, thanks for catching this. We are just about to make a new SOF release and we don't want to break people's setup if they have old kernel and they update sof-bin.

BTW this link was shared in a different (i915/GuC) context:

Revert "soc: intel_adsp: only implement FW_STATUS boot protocol for c…

Fix merged to stable-v2.10 so removing the v2.10 milestone tag. Keeping the bug open until we have the revert in SOF mainline as well.

Revert "soc: intel_adsp: only implement FW_STATUS boot protocol for c…

west.ytml: update to Zephyr 650227d8c47f

Fix merged via #9278

west.ytml: update to Zephyr 650227d8c47f

Revert "soc: intel_adsp: only implement FW_STATUS boot protocol for c…

Navigation Menu

Repository navigation

[BUG] SOF fails to load on MTL (with Linux 6.8 or older driver) #9243

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[BUG] SOF fails to load on MTL (with Linux 6.8 or older driver) #9243

Description

Activity

andyross commented on Jun 19, 2024

kv2019i commented on Jun 19, 2024

marc-hb commented on Jun 19, 2024

kv2019i commented on Jun 20, 2024

kv2019i commented on Jul 4, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions