Skip to content

dai_ssp_set_reg_config: SSPx configuration: Ignoring SSCR1:TSRE SSCR1:RSRE from blob #9026

Closed
Closed
dai_ssp_set_reg_config: SSPx configuration: Ignoring SSCR1:TSRE SSCR1:RSRE from blob#9026
Labels
ZephyrIssues only observed with Zephyr integratedbugSomething isn't working as expected

Description

@marc-hb
marc-hb
opened on Apr 9, 2024

Seems to be printed multiple times in most (passing!) tests on LNL, for instance daily run #/result/planresultdetail/39547?model=LNLM_RVP_NOCODEC&testcase=check-playback-100sec

[  392.350033] <inf> pipe: pipeline_new: pipeline new pipe_id 1 priority 0
[  392.350726] <inf> ipc: ipc_cmd: rx	: 0x40000003|0x201000a
[  392.351050] <inf> ipc: ipc_cmd: rx	: 0x40010006|0x2010010
[  392.351481] <inf> ipc: ipc_cmd: rx	: 0x44010006|0x30000018
[  392.352003] <inf> ipc: ipc_cmd: rx	: 0x40010004|0x2010056
[  392.352075] <inf> dai_intel_ssp: dai_ssp_pm_runtime_en_ssp_power: SSP2
[  392.352098] <inf> dma: dma_get: dma_get() ID 0 sref = 1 busy channels 0
[  392.352105] <inf> ipc: dai_config: comp:1 0x10004 dai_config() dai type = 1 index = 2 dd 0x4010fec0
[  392.352115] <inf> dai_intel_ssp: dai_ssp_parse_aux_data: link clock_source 1
[  392.352118] <err> dai_intel_ssp: dai_ssp_set_reg_config: SSP2 configuration:
[  392.352126] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  Ignoring SSCR1:TSRE SSCR1:RSRE from blob
[  392.352131] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  sscr0 = 0xc1d0077f, sscr1 = 0xd0400004, ssto = 0x00000000, sspsp = 0x2200000
[  392.352136] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  sscr2 = 0x00004002, sspsp2 = 0x00000000, sscr3 = 0x07070000
[  392.352140] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  ssioc = 0x00000020, ssrsa = 0x00000003, sstsa = 0x00000003
[  392.352605] <inf> ipc: ipc_cmd: rx	: 0x45000004|0x6
[  392.352641] <inf> ipc: buffer_new: buffer new size 0x80 id 0.0 flags 0x0
[  392.352653] <inf> pipe: pipeline_connect: comp:0 0x4 connect buffer 0 as sink

Same message with SSP0, SSP1 and SSP2

If this is not an error then the message should be downgraded.

Linux Branch: topic/sof-dev
Linux Commit: 45fa8789fdea
KConfig Branch: master
KConfig Commit: d885ec26b1a9

SOF Branch: main
SOF Commit: 0542687ad921
Zephyr Commit: 1f55be8b42df

EDIT: not platform specific at all, see for instance MTL https://sof-ci.01.org/sofpr/PR8956/build3506/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=check-playback-10sec

EDIT2: this seems to be specific to Zephyr + NOCODEC

cc: @dnikodem (from zephyrproject-rtos/zephyr#70660)

EDIT: error message was added by @ujfalusi in zephyrproject-rtos/zephyr#64604

Activity

  1. marc-hb
    added
    bugSomething isn't working as expected
    LNLApplies to Lunar Lake platform
    on Apr 9, 2024

  2. marc-hb commented on Apr 9, 2024

    @marc-hb
    marc-hb
    on Apr 9, 2024
    CollaboratorAuthor

    This is probably old. We never noticed because we've never caught firmware errors yet:

  3. plbossart commented on Apr 9, 2024

    @plbossart
    plbossart
    on Apr 9, 2024
    Member

    are you sure it's LNL-specific? I think it's a feature of the SSP firmware driver, the blob ignores the bits that enable transmission.

    One could also argue it's possibly the blob that sets those bits in the config - and that's probably a mistake?

  4. marc-hb commented on Apr 9, 2024

    @marc-hb
    marc-hb
    on Apr 9, 2024
    CollaboratorAuthor

    are you sure it's LNL-specific?

    It's not LNL-specfic. I just re-ran thesofproject/sof-test#1075 and I spotted it on MTLP_RVP_NOCODEC. I'll post the link to the full report there once the test run is complete.

    [  164.147556] <inf> dma: dma_get: dma_get() ID 0 sref = 1 busy channels 0
[  164.147563] <inf> ipc: dai_config: comp:1 0x10004 dai_config() dai type = 1 index = 0 dd 0x4011cfc0
[  164.147578] <inf> dai_intel_ssp: dai_ssp_parse_aux_data: link clock_source 1
[  164.147600] <err> dai_intel_ssp: dai_ssp_set_reg_config: SSP0 configuration:
[  164.147611] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  Ignoring SSCR1:TSRE SSCR1:RSRE from blob
[  164.147618] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  sscr0 = 0xc1d0077f, sscr1 = 0xd0400004, ssto = 0x00000000, sspsp = 0x2200000
[  164.147623] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  sscr2 = 0x00004002, sspsp2 = 0x00000000, sscr3 = 0x07070000
[  164.147630] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  ssioc = 0x00000020, ssrsa = 0x00000003, sstsa = 0x00000003
[  164.148055] <inf> ipc: ipc_cmd: rx	: 0x45000004|0x6
[  164.148065] <inf> ipc: buffer_new: buffer new size 0x300 id 0.0 flags 0x0
  5. marc-hb
    added
    MTLApplies to Meteor Lake platform
    on Apr 9, 2024
  6. marc-hb
    changed the title [-][LNL] dai_ssp_set_reg_config: SSPx configuration: Ignoring SSCR1:TSRE SSCR1:RSRE from blob[/-] [+][LNL,MTL] dai_ssp_set_reg_config: SSPx configuration: Ignoring SSCR1:TSRE SSCR1:RSRE from blob[/+] on Apr 9, 2024

  7. marc-hb commented on Apr 9, 2024

    @marc-hb
    marc-hb
    on Apr 9, 2024
    CollaboratorAuthor

    Armed with that new knowledge, I just found a complete, public, MTL test run that has the same error:
    https://sof-ci.01.org/sofpr/PR8956/build3506/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=check-playback-10sec

  8. marc-hb commented on Apr 10, 2024

    @marc-hb
    marc-hb
    on Apr 10, 2024
    CollaboratorAuthor

    Just seen on TGL too:
    https://sof-ci.01.org/softestpr/PR1172/build276/devicetest/index.html?model=TGLU_RVP_NOCODEC-ipc4&testcase=check-playback-10sec

    [  168.610785] <inf> ipc: ipc_cmd: rx	: 0x44010006|0x30000018
[  168.611360] <inf> ipc: ipc_cmd: rx	: 0x40010004|0x1002c
[  168.611446] <inf> dai_intel_ssp: dai_ssp_pm_runtime_en_ssp_power: SSP1
[  168.611478] <inf> dma: dma_get: dma_get() ID 0 sref = 1 busy channels 0
[  168.611493] <inf> ipc: dai_config: comp:1 0x10004 dai_config() dai type = 1 index = 1 dd 0x9e0c8700
[  168.611538] <err> dai_intel_ssp: dai_ssp_set_reg_config: SSP1 configuration:
[  168.611550] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  Ignoring SSCR1:TSRE SSCR1:RSRE from blob
[  168.611565] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  sscr0 = 0xc1d0077f, sscr1 = 0xd0400004, ssto = 0x00000000, sspsp = 0x2200000
[  168.611578] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  sscr2 = 0x00004002, sspsp2 = 0x00000000, sscr3 = 0x07070000
[  168.611590] <inf> dai_intel_ssp: dai_ssp_set_reg_config:  ssioc = 0x00000020, ssrsa = 0x00000003, sstsa = 0x00000003
[  168.613801] <inf> ipc: ipc_cmd: rx	: 0x45000004|0x6
[  168.613835] <inf> ipc: buffer_new: buffer new size 0x300 id 0.0 flags 0x0
[  168.613866] <inf> pipe: pipeline_connect: comp:0 0x4 connect buffer 0 as sink
  9. marc-hb
    transferred this issue fromthesofproject/linuxon Apr 10, 2024

  10. marc-hb commented on Apr 10, 2024

    @marc-hb
    marc-hb
    on Apr 10, 2024
    CollaboratorAuthor

    Based on thesofproject/sof-test#1075 (comment) results this seems to be a NOCODEC thing.

    NOCODEC reproduction rate: 100%
    "codec" reproduction rate: 0%

  11. marc-hb
    changed the title [-][LNL,MTL] dai_ssp_set_reg_config: SSPx configuration: Ignoring SSCR1:TSRE SSCR1:RSRE from blob[/-] [+]dai_ssp_set_reg_config: SSPx configuration: Ignoring SSCR1:TSRE SSCR1:RSRE from blob[/+] on Apr 10, 2024
  12. marc-hb
    added
    ZephyrIssues only observed with Zephyr integrated
    and removed
    MTLApplies to Meteor Lake platform
    LNLApplies to Lunar Lake platform
    on Apr 10, 2024

  13. 3 remaining items

  14. marc-hb commented on Apr 10, 2024

    @marc-hb
    marc-hb
    on Apr 10, 2024
    CollaboratorAuthor

    It's not an error really, it's a feature but that's really not important to log.

    So, just downgrade to the message to WARN level?

  15. plbossart commented on Apr 10, 2024

    @plbossart
    plbossart
    on Apr 10, 2024
    Member

    Warn is even too high IMHO, it's a known behavior. Nothing different to expect. dev_dbg() is probably fine.

  16. marc-hb commented on Apr 11, 2024

    @marc-hb
    marc-hb
    on Apr 11, 2024
    CollaboratorAuthor

    The LOG_ERR was actually added by zephyrproject-rtos/zephyr@6423bc3bc885 and the level looks clearly unintentional there. I'm submitting a fix.

  17. marc-hb
    added a commit that references this issue on Apr 11, 2024

    drivers: dai: intel: ssp: fix LOG_ERR level / false positive

    736d95d
  18. marc-hb
    removed
    P1Blocker bugs or important features
    on Apr 11, 2024

  19. ujfalusi commented on Apr 11, 2024

    @ujfalusi
    ujfalusi
    on Apr 11, 2024
    Contributor

    The dai_intel_ssp: dai_ssp_set_reg_config: SSP2 configuration: is in wrong level, it should be info, sending a fix right away.

  20. ujfalusi commented on Apr 11, 2024

    @ujfalusi
    ujfalusi
    on Apr 11, 2024
    Contributor

    @marc-hb, I see you already done that, thanks!

  21. nashif
    added a commit that references this issue on Apr 11, 2024

    drivers: dai: intel: ssp: fix LOG_ERR level / false positive

    1708122
  22. coreboot-bot
    added a commit that references this issue on Apr 13, 2024

    drivers: dai: intel: ssp: fix LOG_ERR level / false positive

    46fc975

  23. lgirdwood commented on Apr 16, 2024

    @lgirdwood
    lgirdwood
    on Apr 16, 2024
    Member

    @marc-hb can we close ?

  24. marc-hb commented on Apr 16, 2024

    @marc-hb
    marc-hb
    on Apr 16, 2024
    CollaboratorAuthor

    I don't think we've updated Zephyr that far yet.

    EDIT: indeed not yet, manifest still at Zephyr commit 2ccf775396c2 right now.

  25. marc-hb commented on Apr 23, 2024

    @marc-hb
    marc-hb
    on Apr 23, 2024
    CollaboratorAuthor

    Zephyr updated, we have the fix now. INF level in https://sof-ci.01.org/softestpr/PR1075/build327/devicetest/index.html

  26. marc-hb
    closed this as completedon Apr 23, 2024
  27. jma-phytec
    added a commit that references this issue on Jun 9, 2026

    drivers: dai: intel: ssp: fix LOG_ERR level / false positive

    41547c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ZephyrIssues only observed with Zephyr integratedbugSomething isn't working as expected

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions