You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[BUG] Topology2: need to set SAMPLE_TYPE_MSB_INTEGER for dai copier #8343
Describe the bug
Now Firmware adjusts valid format in copier according to sample type.
We need to set SAMPLE_TYPE_MSB_INTEGER for all 24 bit format dai copiers. #8151 did the job for the existing topologies.
However, we need to remember to do the same change when we add new 24 bit dai copier support. The issue is just a reminder.
Playback output will be no sound if we don't do the change.
To Reproduce
Test 24 bit format with SAMPLE_TYPE_LSB_INTEGER out_sample_type
Reproduction Rate
100%
Expected behavior
Playback output is audible.
Impact
It is not acceptable if playback output no sound.
Environment
SOF: After v2.7
Name of the topology file
Topology: Without the out_sample_type change
Name of the platform(s) on which the bug is observed.
Activity
lgirdwood commentedon Oct 18, 2023
@bardliao I think @RanderWang did some checking of formats a few months ago. Best to have a quick check with him too.
bardliao commentedon Nov 16, 2023
Closing it as #8359 has been merged.