Skip to content

[BUG] Rimage revision defined in git submodule does not match the one defined in west.yml manifest #7781

Closed

Description

@aborisovich

Describe the bug
Git submodule rimage revision had not been updated during last update of the west.yml file.
Looks like regression introduced in the #7630 .
It had been changed in west manifest from ab0429f to
4ce79b1 however, during work with git rimage submodule shows changes.

To Reproduce

  1. execute command west update
  2. execute command git status (now rimage submodule has changes - dirty state)
  3. execute command git submodule update --init --recursive and confirm that SHA ab0429f is checked out (bad revision).

Reproduction Rate
100%.

Expected behavior
Git status does not show changes in rimage submodule.

Impact
Annoyance.

Environment

  1. Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
    • Kernel: N/A
    • SOF: main
  2. Name of the topology file
    • Topology: N/A
  3. Name of the platform(s) on which the bug is observed.
    • Platform: Zephyr platforms

Screenshots or console output
rimage bad revision.log

Activity

  1. added
    bugSomething isn't working as expected
    P3Low-impact bugs or features
    ZephyrIssues only observed with Zephyr integrated
    on Jun 12, 2023
  2. aborisovich commented on Jun 12, 2023

    @aborisovich
    ContributorAuthor

    @fredoh9 please double check whether your PR introduces this and fix if I am right.
    Guys please take cautious with this. I know it's tiresome to track revision in both git and west but please do so until we migrate to west completely.

  3. marc-hb commented on Jun 12, 2023

    @marc-hb
    Collaborator

    I think it was not @fredoh9 but @andyross in 7511a1d

    EDIT: fix submitted in

  4. marc-hb commented on Jun 12, 2023

    @marc-hb
    Collaborator

    99.99% sure this has just been fixed by #7782 but please re-open if I got it wrong.

  5. aborisovich commented on Jun 13, 2023

    @aborisovich
    ContributorAuthor

    Yes fixed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3Low-impact bugs or featuresZephyrIssues only observed with Zephyr integratedbugSomething isn't working as expected

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions