You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[BUG] Rimage revision defined in git submodule does not match the one defined in west.yml manifest #7781
Describe the bug
Git submodule rimage revision had not been updated during last update of the west.yml file.
Looks like regression introduced in the #7630 .
It had been changed in west manifest from ab0429f to 4ce79b1 however, during work with git rimage submodule shows changes.
To Reproduce
execute command west update
execute command git status (now rimage submodule has changes - dirty state)
execute command git submodule update --init --recursive and confirm that SHA ab0429f is checked out (bad revision).
Reproduction Rate
100%.
Expected behavior Git status does not show changes in rimage submodule.
Impact
Annoyance.
Environment
Branch name and commit hash of the 2 repositories: sof (firmware/topology) and linux (kernel driver).
Kernel: N/A
SOF: main
Name of the topology file
Topology: N/A
Name of the platform(s) on which the bug is observed.
@fredoh9 please double check whether your PR introduces this and fix if I am right.
Guys please take cautious with this. I know it's tiresome to track revision in both git and west but please do so until we migrate to west completely.
Activity
aborisovich commentedon Jun 12, 2023
@fredoh9 please double check whether your PR introduces this and fix if I am right.
Guys please take cautious with this. I know it's tiresome to track revision in both git and west but please do so until we migrate to west completely.
marc-hb commentedon Jun 12, 2023
I think it was not @fredoh9 but @andyross in 7511a1d
EDIT: fix submitted in
marc-hb commentedon Jun 12, 2023
99.99% sure this has just been fixed by #7782 but please re-open if I got it wrong.
aborisovich commentedon Jun 13, 2023
Yes fixed, thanks.