Repository navigation
[BUG][IPC4] fix 24bit variant type support #7697
Description
Describe the bug
See kernel side bug fro background and description
thesofproject/linux#4383
FW should honor MSB_INTEGER/LSB_INTEGER in IPC4 audio_format definiton.
IPC3 did not make a distinction between the two variants, so this has been wrong in both kernel and FW, but this needs to be addressed.
FYI @RanderWang @serhiy-katsyuba-intel @abonislawski @singalsu
Activity
kv2019i commentedon May 31, 2023
The current SOF mainline ignores the copier config for DAI side and chooses the LSB/MSB variant based on interface type:
#7573
.... and sample_type is not considered here at all (in current SOF).
kv2019i commentedon Jun 29, 2023
This is trending to be an invalid bug. Based on survey of test cases, it would seem host should always use MSB_INTEGER for 16/24/32 bit integer sample formats. The firmware is doing bit shifts between ALSA S32_LE and S24_LE presentations based on DAI type when setting up the DAI copier (e.g. HDA interface specifies a certain layout that comes from the standard, so FW will use this layout no matter what is specified in the module configuration (audio format in topology).