Add timeout for HDA DMA Buffer full wait to avoid FW hang #723

Activity

1. keyonjie

   added

   blockedprogress blocked by something else, applies to either feature or bugprogress blocked by something else, applies to either feature or bug

   on Dec 14, 2018
2. keyonjie

   assigned

   mmaka1

   on Dec 14, 2018
3. keyonjie commented on Dec 14, 2018

   

   keyonjie

   on Dec 14, 2018

   ContributorAuthor

   More actions

   @mmaka1 Hi Marcin, I am assigning this to you, please feel free to assign it to anybody in your team who can help on it.
4. ranj063

   removed

   blockedprogress blocked by something else, applies to either feature or bugprogress blocked by something else, applies to either feature or bug

   on Dec 14, 2018
5. keyonjie

   assigned

   abonislawski

   on Dec 17, 2018
6. lgirdwood commented on Dec 17, 2018

   

   lgirdwood

   on Dec 17, 2018

   Last edited by lgirdwood

   Member

   More actions

   Lets make this timeout PLATFORM specific and define in platform.h
7. keyonjie

   added

   APLApplies to Apollolake platformApplies to Apollolake platform

   P1Blocker bugs or important featuresBlocker bugs or important features

   on Dec 27, 2018
8. keyonjie commented on Dec 27, 2018

   

   keyonjie

   on Dec 27, 2018

   ContributorAuthor

   More actions

   some local change which actually workaround this issue:

   diff --git a/src/drivers/intel/cavs/hda-dma.c b/src/drivers/intel/cavs/hda-dma.c
   index 7250f68d..9ea45906 100644
   --- a/src/drivers/intel/cavs/hda-dma.c
   +++ b/src/drivers/intel/cavs/hda-dma.c
   @@ -327,12 +327,14 @@ static int hda_dma_host_preload(struct dma *dma, struct hda_chan_data *chan)
           };
           int i;
           int period_cnt;
   +       int count = 20;
    
           /* waiting for buffer full after start
            * first try is unblocking, then blocking
            */
           while (!(host_dma_reg_read(dma, chan->index, DGCS) & DGCS_BF) &&
   -              (chan->state & HDA_STATE_BF_WAIT))
   +//            (chan->state & HDA_STATE_BF_WAIT))
   +              (chan->state & HDA_STATE_BF_WAIT) && (count-- > 0))
                   ; /* TODO: this should timeout and not wait forever */
    
           if (host_dma_reg_read(dma, chan->index, DGCS) & DGCS_BF) {
   @@ -348,7 +350,9 @@ static int hda_dma_host_preload(struct dma *dma, struct hda_chan_data *chan)
                   }
           } else {
                   /* next call in pre-load state will be blocking */
   -               chan->state |= HDA_STATE_BF_WAIT;
   +//             chan->state |= HDA_STATE_BF_WAIT;
   +               
   +               chan->state &= ~(HDA_STATE_HOST_PRELOAD | HDA_STATE_BF_WAIT);
           }
    
           return 0;
   
9. jajanusz

   self-assigned this

   on Dec 27, 2018
10. jajanusz commented on Dec 27, 2018

    

    jajanusz

    on Dec 27, 2018

    Contributor

    More actions

    @keyonjie
    Please check if #783 is good enough for you. There are no reproduction steps, so I didn't test it.
11. mengdonglin

    added

    bugSomething isn't working as expectedSomething isn't working as expected

    on Dec 28, 2018
12. wenqingfu commented on Jan 9, 2019

    

    wenqingfu

    on Jan 9, 2019

    More actions

    according to the discussion in #783 , this issue can be closed. @keyonjie will open new issue if there are timeouts on top of it. Please be sure to include more details how to reproduce it next time.
13. wenqingfu

    closed this as completedon Jan 9, 2019