[BUG] addition of AMD_HS breaks backwards compatibility #6615

Activity

1. plbossart

   added

   bugSomething isn't working as expectedSomething isn't working as expected

   P1Blocker bugs or important featuresBlocker bugs or important features

   on Nov 16, 2022
2. plbossart commented on Nov 16, 2022

   

   plbossart

   on Nov 16, 2022

   MemberAuthor

   More actions

   To make things worse, new DAI types were added to the kernel definitions but not in the SOF tree. WTH?

   kernel:

   /** \brief Types of DAI */
   enum sof_ipc_dai_type {
   	SOF_DAI_INTEL_NONE = 0,		/**< None */
   	SOF_DAI_INTEL_SSP,		/**< Intel SSP */
   	SOF_DAI_INTEL_DMIC,		/**< Intel DMIC */
   	SOF_DAI_INTEL_HDA,		/**< Intel HD/A */
   	SOF_DAI_INTEL_ALH,		/**< Intel ALH  */
   	SOF_DAI_IMX_SAI,		/**< i.MX SAI */
   	SOF_DAI_IMX_ESAI,		/**< i.MX ESAI */
   	SOF_DAI_AMD_BT,			/**< AMD ACP BT*/
   	SOF_DAI_AMD_SP,			/**< AMD ACP SP */
   	SOF_DAI_AMD_DMIC,		/**< AMD ACP DMIC */
   	SOF_DAI_AMD_HS,			/**< Amd HS */
   	SOF_DAI_MEDIATEK_AFE,		/**< Mediatek AFE */
   	SOF_DAI_AMD_SP_VIRTUAL,		/**< AMD ACP SP VIRTUAL */
   	SOF_DAI_AMD_HS_VIRTUAL,		/**< AMD ACP HS VIRTUAL */
   };
   

   firmware

   /** \brief Types of DAI */
   enum sof_ipc_dai_type {
   	SOF_DAI_INTEL_NONE = 0,		/**< None */
   	SOF_DAI_INTEL_SSP,		/**< Intel SSP */
   	SOF_DAI_INTEL_DMIC,		/**< Intel DMIC */
   	SOF_DAI_INTEL_HDA,		/**< Intel HD/A */
   	SOF_DAI_INTEL_ALH,		/**< Intel ALH */
   	SOF_DAI_IMX_SAI,                /**< i.MX SAI */
   	SOF_DAI_IMX_ESAI,               /**< i.MX ESAI */
   	SOF_DAI_AMD_BT,			/**< Amd BT */
   	SOF_DAI_AMD_SP,			/**< Amd SP */
   	SOF_DAI_AMD_DMIC,		/**< Amd DMIC */
   	SOF_DAI_AMD_HS,			/**< Amd HS */
   	SOF_DAI_MEDIATEK_AFE            /**< Mtk AFE */
   };
   
3. ranj063 commented on Nov 16, 2022

   

   ranj063

   on Nov 16, 2022

   Collaborator

   More actions

   To make things worse, new DAI types were added to the kernel definitions but not in the SOF tree. WTH?
   @plbossart I asked this question in the kernel PR but it was merged even before
4. plbossart

   added 4 commits that reference this issue on Nov 16, 2022

   dai: move AMD_HS to end of list to restore backwards-compatibility

   ...

   c0a1d8c

   ASoC: SOF: dai: move AMD_HS to end of list to restore backwards-compa…

   ...

   7a448d1

   ASoC: SOF: dai: move AMD_HS to end of list to restore backwards-compa…

   ...

   e793252

   ASoC: SOF: dai: move AMD_HS to end of list to restore backwards-compa…

   ...

   0438de0
5. lgirdwood

   added a commit that references this issue on Nov 21, 2022

   dai: move AMD_HS to end of list to restore backwards-compatibility

   ...

   c601f7d
6. mengdonglin commented on Dec 6, 2022

   

   mengdonglin

   on Dec 6, 2022

   Collaborator

   More actions

   Fixes merged.
7. mengdonglin

   closed this as completedon Dec 6, 2022
8. Zames-Chang

   added 2 commits that reference this issue on Dec 12, 2022

   dai: move AMD_HS to end of list to restore backwards-compatibility

   ...

   2b9d321

   dai: move AMD_HS to end of list to restore backwards-compatibility

   ...

   ba6a29d
9. sihawken

   added a commit that references this issue on Dec 9, 2025

   UPSTREAM: ASoC: SOF: dai: move AMD_HS to end of list to restore backw…

   ...

   41bccb3