Skip to content

Regression: sof-logger doesn't work with -t parameter #551

Closed

Description

@keqiaozhang

This is a firmware regression and it's caused by commit: 9af90ce
PR #530

error message:

chronos@localhost /root $ sudo ./sof-logger -l sof-apl.ldc -t
Password:
 CORE  LEVEL  COMP_ID        TIMESTAMP            DELTA                FILE_NAME        CONTENT
Error: Invalid filename length.

Activity

  1. added
    bugSomething isn't working as expected
    APLApplies to Apollolake platform
    P1Blocker bugs or important features
    GLKApplies to Gemini Lake platform
    on Nov 8, 2018
  2. changed the title [-]sof-logger doesn[/-] [+]sof-logger doesn't work with -t parameter[/+] on Nov 8, 2018
  3. changed the title [-]sof-logger doesn't work with -t parameter[/-] [+]Regression: sof-logger doesn't work with -t parameter[/+] on Nov 8, 2018
  4. akloniex commented on Nov 8, 2018

    @akloniex
    Member

    @lgirdwood @bkokoszx @keqiaozhang
    Issue is caused by misalignment between FW and sof-logger.
    Expected to be solved as soon as thesofproject/soft#118 is merged and sof-logger rebuilt.

  5. mengdonglin commented on Nov 8, 2018

    @mengdonglin
    Collaborator

    @akloniex @lrgirdwo May we request any PR/commit with ABI change add keyword "ABI" in the subject to highlight the risk? And this PR should mention the soft PR in the body. Ideally, the SOFT update should be backward compatible and be merged at first before the SOF PR.

  6. ZhendanYang commented on Nov 9, 2018

    @ZhendanYang

    sof-logger doesn't work even without -t on CNL:

    test@test-CannonLake:~$ sudo ./sof-logger -l sof-cnl.ldc-11.9
     CORE  LEVEL  COMP_ID        TIMESTAMP            DELTA                FILE_NAME	CONTENT
    Error: Invalid filename length. 
    test@test-CannonLake:~$ sudo ./sof-logger -l sof-cnl.ldc-11.9 -t
     CORE  LEVEL  COMP_ID        TIMESTAMP            DELTA                FILE_NAME	CONTENT
    Error: Invalid filename length. 
    
  7. mengdonglin commented on Nov 9, 2018

    @mengdonglin
    Collaborator

    @bkokoszx Are all the PR low necessary to fix this issue? Anything missing?

    SOFT: thesofproject/soft#118
    FW part: #530
    Linux part: thesofproject/linux#222

  8. bkokoszx commented on Nov 9, 2018

    @bkokoszx
    Collaborator

    @mengdonglin
    Also FW PR I've made yesterday: #548

  9. bkokoszx commented on Nov 9, 2018

    @bkokoszx
    Collaborator

    @keqiaozhang
    Could you verify if issue still reproduces?

  10. keqiaozhang commented on Nov 13, 2018

    @keqiaozhang
    CollaboratorAuthor

    @bkokoszx
    Confirmed that this issue is fixed on UP^2.
    For Yorp, there's one blocker issue with top sof-master :thesofproject/linux#277
    so there's no trace log available, but the "Error: Invalid filename length." is gone.
    @markyang
    please help to confirm this issue on other platform. Thanks~

  11. markyang commented on Nov 13, 2018

    @markyang

    @bkokoszx @keqiaozhang
    This issue has been fixed on BYT, APL and CNL.

  12. removed
    APLApplies to Apollolake platform
    on Nov 13, 2018
  13. markyang commented on Nov 13, 2018

    @markyang

    There's no trace log available on BYT because of a blocker issue thesofproject/linux#233

  14. keqiaozhang commented on Nov 13, 2018

    @keqiaozhang
    CollaboratorAuthor

    Thanks @markyang for your confirmation, this issue can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GLKApplies to Gemini Lake platformP1Blocker bugs or important featuresbugSomething isn't working as expected

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions