Repository navigation
[BUG] [Zephyr] Wrong rimage signing schema used when building for IPC4 #5335
Description
Describe the bug
When SOF is built for IPC4, a different signing schema (e.g. "tgl-cavs") must be used.
When building for Zephyr, signing schema is not change and resulting image is not correct.
Zephyr signing tool (west zephyr/scripts/west_commands/sign.py) takes the target from RIMAGE_TARGET.
SOF scripts to build with IPC4 should specify an alternative target RIMAGE_TARGET when building for Zephyr&IPC4.
In XTOS build, matching logic is in src/arch/xtensa/CMakeLists.txt and set via config override:
sof/src/arch/xtensa/configs/override/tigerlake_ipc4.config (from #5227)
Original report from @XiaoyunWu6666 and @aiChaoSONG
- [BUG] [Zephyr] Wrong rimage signing schema used when building for IPC4 #5335
- [RFC][CI] Build SOF on Zephyr with IPC4 #5357
- script: sign.py: support to override rimage sign schema zephyrproject-rtos/zephyr#42724
- boards/intel_adsp_cavs25: set different rimage target for IPC4 zephyrproject-rtos/zephyr#42949
- sign.py: stop ignoring the -- -c foo.toml option passed to rimage zephyrproject-rtos/zephyr#42993
Activity
lgirdwood commentedon Feb 10, 2022
@marc-hb IIUC, you have a few WIP PRs to support Zephyr. Do any cover this ?
aiChaoSONG commentedon Feb 11, 2022
I filed a patch on zephyr side to add sign schema overriding support zephyrproject-rtos/zephyr#42724. @lgirdwood @kv2019i @lyakh not sure they will accept it.
lgirdwood commentedon Feb 11, 2022
Thanks @aiChaoSONG I've added the relevant folks to discuss in Zpehyr.
lgirdwood commentedon Feb 16, 2022
Moving to v2.2 since this is related to IPC4
marc-hb commentedon Feb 18, 2022
Not sure what you're referring to sorry. In any case I don't have any WIP related to this.
marc-hb commentedon Feb 19, 2022
Well now I have. A bit:
aiChaoSONG commentedon Feb 28, 2022
Correct rimage sign schema on sof side: #5412.
Another is to use cmake to sign firmware, but not sure when it will be implemented. because we already have one fix to use, let's close this for now.