Repository navigation
[FEATURE] Update and remove passthrough definitions #4487
Description
some components have outdated manual copy code, we need to clean these up with the new audio_stream_copy function.
Current spotted ones are:
- Crossover This works because the definition of
audio_stream_copydoes not include updating the buffer r/w - IGO NR module not entirely necessary, just would allow a bypass of the whole interleave/deinterleave logic
I will need to see if there are any others but a quick search for "passthrough" yielded the above results.
Activity
kv2019i commentedon Feb 15, 2023
@cujomalainey @johnylin76 @fuyuntsuo Cleaning up our milestone 1.9 leftovers and this got picked in the filter. It seems this would be still valid. I'll bump it to v2.6 for now.
lgirdwood commentedon May 10, 2023
@andrula-song @singalsu I assume all modules now using optimal copy/processing API/loops now. Can we close ?
singalsu commentedon May 15, 2023
@lgirdwood The crossover and igo_nr are still using the read/write frag function in a MCPS expensive way. We will convert both to module adapter in this Q2 that will address this issue too.
alex-cri commentedon May 30, 2023
Moving to v2.7 for the remaining items to be addressed.
lgirdwood commentedon Jul 4, 2023
@singalsu @andrula-song any update, I guess most modules now optimized, can we close ?
andrula-song commentedon Jul 5, 2023
checked the code, igo_nr still not converted to module_adapter interface. I am afraid we can not close it now.
6 remaining items
lgirdwood commentedon Apr 17, 2024
@singalsu whats remaining effort for crossover ?
kv2019i commentedon Jun 5, 2024
v2.10 cut @singalsu @lgirdwood , crossover still open, moving to 2.11.
kv2019i commentedon Dec 13, 2024
Feature cutoff for v2.12 today, what's the status with cross-over?
johnylin76 commentedon Dec 16, 2024
sorry for the late reply, uploaded #9726 for review
kv2019i commentedon Jan 3, 2025
Thanks all, with crossover converted, we can finally close this.