[BUG]/scripts/build-tools.sh -T doesn't build development topologies #4141

Activity

1. dbaluta

   added

   bugSomething isn't working as expectedSomething isn't working as expected

   on May 5, 2021
2. lgirdwood commented on May 5, 2021

   

   lgirdwood

   on May 5, 2021

   Member

   More actions

   @singalsu fyi - I assume this is a regression ? @marc-hb fyi.
3. marc-hb commented on May 5, 2021

   

   marc-hb

   on May 5, 2021

   Collaborator

   More actions

   They're built only when building everything. Demo:

   rm tools/topology/development/sof-apl-dmic-asymmetric.m4 
   ./scripts/build-tools -T # does not care about /development/
   ./scripts/build-tools    # tries to build /development.
   

   This single line is enough to change that:

   --- a/tools/topology/development/CMakeLists.txt
   +++ b/tools/topology/development/CMakeLists.txt
   @@ -34,6 +34,7 @@ set(TPLGS_UP
    )
    
    add_custom_target(dev_topologies ALL)
   +add_dependencies(topologies dev_topologies)
    
    foreach(tplg ${TPLGS})
    	list(GET tplg 0 input)

   However I have no idea whether that's desirable or not. I think @plbossart, @ranj063 have some informed opinions on what topologies should be built and when? A new tools/topology/README.md would not hurt.

   I assume this is a regression

   No idea but there hasn't been any recent change AFAICT
4. fredoh9 commented on May 5, 2021

   

   fredoh9

   on May 5, 2021

   Contributor

   More actions

   From SOF-CI, we use "scripts/build-tools.sh" without any option. We should build all.
   But I checked on the storage server, I couldn't find development tplg files. Maybe we have some bugs when copying output.
5. fredoh9 commented on May 5, 2021

   

   fredoh9

   on May 5, 2021

   Contributor

   More actions

   Sorry for a bit off the topic. This issue started with -T option...

   For the storage server, there was my misunderstanding. There is no development directory, but all files are under tplg directories. I don't think we have any platform to use development's topology, I think, we are keeping flat directory structure for sake of simplifying deploy script. We have more option to do so also. I created an internal issue to discuss that.
6. dbaluta commented on May 6, 2021

   

   dbaluta

   on May 6, 2021

   CollaboratorAuthor

   More actions

   @fredoh9 thanks for your explanations.
   To sum up:

   • ./scripts/build-tools.sh -T only builds topologies in the main directory
   • if one wants to build topologies in development directory there is the option to run ./scripts/build-tools.sh with no params.
7. dbaluta

   closed this as completedon May 6, 2021
8. marc-hb commented on May 18, 2021

   

   marc-hb

   on May 18, 2021

   Collaborator

   More actions

   I got tired of this confusion too and I submitted #4210
9. marc-hb

   added 2 commits that reference this issue on May 22, 2021

   .github: add build-tools.sh (all) back, lost with Travis

   ...

   451c62e

   scripts/build-tools: some usage and other clarifications

   ...

   be1312a
10. cujomalainey

    added 2 commits that reference this issue on May 24, 2021

    .github: add build-tools.sh (all) back, lost with Travis

    ...

    cc3b302

    scripts/build-tools: some usage and other clarifications

    ...

    e69e1c7
11. marc-hb commented on Dec 10, 2021

    

    marc-hb

    on Dec 10, 2021

    Last edited by marc-hb

    Collaborator

    More actions

    if one wants to build topologies in development directory there is the option to run ./scripts/build-tools.sh with no params.

    Except for this "install" race condition I just discovered: #5067

    But I checked on the storage server, I couldn't find development tplg files. Maybe we have some bugs when copying output.

    Maybe that's why.