Skip to content

[BUG][DSM] Channel 3,4 are empty when testing with S16_LE format #2679

Closed

Description

@keqiaozhang

Describe the bug
Tested the DSM on TGL, S24_4LE and S32_LE are working well. but when testing with S16_LE format, channel 3 and 4 are empty in the recorded wav. From waveform, it looks like the data of channel 3 and 4 are mixed in channel 1 and 2.

DSM

To Reproduce
aplay -Dhw:0,0 -f S16_LE -r 48000 -c2 sine_s16_le_48k.wav --dump-hw-params & arecord -Dhw:0,0 -f S16_LE -r 48000 -c 4 -d 10 DSM.wav -vv

Reproduction Rate
5/5

Expected behavior
channel 3,4 should also have data

Impact
no data in Channel 3 and 4, and channel 1 and 2 data are also wrong.

Environment

  1. Kernel: thesofproject/linux topic/smart-amp
  2. Sof: thesofproject/sof tgl-004-drop-stabe
  3. Tplg: sof-tgl-smart-amplifier.m4 (rename it to sof-tgl-nocodec.tplg
  4. Platform:TGL

trace-dsm.txt
dmesg-dsm.txt

Activity

  1. added
    bugSomething isn't working as expected
    TGLApplies to Tiger Lake
    on Apr 1, 2020
  2. slawblauciak commented on Apr 1, 2020

    @slawblauciak
    Collaborator

    Low priority for now, this format is not supported currently.

  3. paulstelian97 commented on Apr 1, 2020

    @paulstelian97
    Collaborator

    Probably the DMA engine is still configured for 4 bytes per elementary transfer instead of 2? Who's the owner of the DMA engine on this platform?

  4. lgirdwood commented on Apr 1, 2020

    @lgirdwood
    Member

    Isn't demux/mux used here ? see #2687

  5. keqiaozhang commented on Apr 27, 2020

    @keqiaozhang
    CollaboratorAuthor

    This issue is fixed in tgl-005-drop-stable branch. We tested it on Volteer-I2S and this issue is not reproducible.
    Test recipe:
    Driver: fce7f93 + thesofproject/linux#1971 + https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-next&id=914f674bec6efe42f9d6b036850a618fd1698290
    Firmware:
    SOF branch: tgl-005-drop-stable Commit: 277a971
    TPLG: sof-tgl-max98373-rt5682.tplg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    DSMDynamic Speaker ManagementP3Low-impact bugs or featuresTGLApplies to Tiger LakebugSomething isn't working as expected

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions