Repository navigation
[BUG] unsupported widget type asrc when run build-tools.sh #2543
Description
The SND_SOC_TPLG_DAPM_ASRC is delete from upstream alsa-lib(src/topology/damp.c: line24~line48), so topologies contain ASRC component will be failed to build. we got :widget 'ASRC1.0': unsupported widget type asrc error when running build-tools.sh -T
alsa-lib commit which makes the change: alsa-project/alsa-lib@aa1bac2
[ 18%] Generating sof-hda-asrc-2ch.tplg (same error for sof-apl-asrc-wm8804.tplg, sof-apl-asrc-pcm512x.tplg)
cd sof/tools/build_tools/topology && alsatplg ${VERBOSE:+-v 1} -c sof-hda-asrc-2ch.conf -o sof-hda-asrc-2ch.tplg
ALSA lib dapm.c:547:(tplg_parse_dapm_widget) widget 'ASRC1.0': Unsupported widget type asrc
ALSA lib parser.c:213:(tplg_load_config) failed to parse topology
Unable to load configuration: Invalid argument
make[2]: *** [topology/CMakeFiles/topology_sof-hda-asrc-2ch.dir/build.make:61: topology/sof-hda-asrc-2ch.tplg] Error 1
make[2]: Leaving directory '/build/SOF/sof/tools/build_tools'
make[1]: *** [CMakeFiles/Makefile2:862: topology/CMakeFiles/topology_sof-hda-asrc-2ch.dir/all] Error 2
make[1]: Leaving directory '/build/SOF/sof/tools/build_tools'
make: *** [Makefile:130: all] Error 2
Activity
aiChaoSONG commentedon Mar 13, 2020
@lgirdwood @plbossart What are we going to do with this?
lgirdwood commentedon Mar 13, 2020
@aiChaoSONG can you bisect to see when this was removed and who did it ?
tlauda commentedon Mar 13, 2020
@lgirdwood It's already in the bug:
plbossart commentedon Mar 13, 2020
@aiChaoSONG Sorry I don't get what you meant by 'delete from upstream'. It was never added?
@singalsu you've added those topologies with ASRC, did you face any issues with alsa-lib?
singalsu commentedon Mar 13, 2020
I haven't got this issue. I've run tools build with various recent Ubuntu Linuxes. There has no more been need to use alsa tools git version to create SOF topologies.
Why is ASRC being removed from ALSA?
tlauda commentedon Mar 13, 2020
It looks like some kind of accidental removal?
Maybe @perexg could elaborate.
topology: add back asrc to widget_map in dapm.c
perexg commentedon Mar 13, 2020
Yep, it's accidental removal. Fixed in alsa-lib's master. Thanks for the note.
marc-hb commentedon Mar 25, 2020
FWIW reproduced with out-of-the-box alsa-lib 1.2.2-1.fc31
marc-hb commentedon May 13, 2020
While no release includes the v1.2.2-6-gcaf77a93cef5 fix yet, it has been cherry-picked in the
alsa-git.patchof alsa-utils version 1.2.2 -2 .fc31 https://koji.fedoraproject.org/koji/rpminfo?rpmID=21111550On Ubuntu 20.04,
alsa-utilslibatopology21.2.2-1ubuntu1does not have this fix.scripts/build-tools.sh: let user override NO_PROCESSORS
marc-hb commentedon Jun 22, 2020
Here's a quick, dirty and lazy workaround for this situation:
See PR
scripts: build-tools.sh: Make tools individually buildable#3064 for more backgroundmarc-hb commentedon Oct 1, 2020
Fix still not cherry-picked by Ubuntu 20.04 in
libatopology2 1.2.2-2.1ubuntu2Fix still not cherry-picked by Ubuntu 20.04 in
libatopology2 1.2.2-2.1ubuntu2.12022 EDIT: this will likely never get fixed in Ubuntu 20.04 LTS. It's fixed in the ALSA version part of Ubuntu 22.04
.github: testbench: stop using container to build test topologies