Repository navigation
sof-get-default-tplg.sh: return full /lib/firmware/sof-tplg/*.tplg path - #854
Merged
Merged
Conversation
This fixes the confusion between (for instance) /lib/firmware/intel/avs-tplg/sof-hda-generic-idisp.tplg and /lib/firmware/intel/sof-tplg/sof-hda-generic-idisp.tplg The other option was to return `sof-tplg/sof-hda-generic-idisp.tplg` but this would have required all users of this script to adapt whereas this change will hopefully go unnoticed. Also add some error handling, comments and other cleanups. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
ranj063
approved these changes
Feb 10, 2022
Collaborator
Author
|
https://sof-ci.01.org/softestpr/PR854/build974/devicetest/?model=CML_RVP_SDW&testcase=check-suspend-resume-5 is our good old friend
https://sof-ci.01.org/softestpr/PR854/build974/devicetest/?model=APL_UP2_NOCODEC&testcase=check-suspend-resume-with-capture-5 is a unfortunately usual rtcwake timeout None is related to this test change. |
marc-hb
requested review from
XiaoyunWu6666,
aiChaoSONG,
fredoh9 and
keqiaozhang
February 10, 2022 00:12
aiChaoSONG
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the confusion between (for instance)
and
The other option was to return
sof-tplg/sof-hda-generic-idisp.tplgbutthis would have required all users of this script to adapt whereas this
change will hopefully go unnoticed.
Also add some error handling, comments and other cleanups.
Signed-off-by: Marc Herbert marc.herbert@intel.com