Repository navigation
sof_insert: load snd-sof-pci/acpi _before_ they're loaded automatically - #852
Conversation
| insert_module snd_sof_acpi_intel_byt | ||
| insert_module snd_sof_acpi_intel_bdw | ||
|
|
||
| insert_module snd_sof_pci # ipc_type=1 sof_pci_debug=1 ... |
There was a problem hiding this comment.
we already pass parameters with options snd_sof_pci ipc_type=1 in a /etc/modprobe.d/something.conf
That could conflict or become inconsistent. I am not sure we want to add module parameters here, we only wanted to manage the dependencies.
To your point though it makes no sense to add them last, I think this is a left-over from earlier versions before we flipped the dependencies.
There was a problem hiding this comment.
The ipc_type comment is only a quick hack useful locally, it's never meant to be committed and used in production. I will add a comment to clarify this (DONE)
It's useful locally because it shows up in "git diff" whereas changes in /etc/ are usually forgotten. Version control everything.
We already had this discussion in #734 :-)
|
https://sof-ci.01.org/softestpr/PR852/build972/devicetest/?model=APL_UP2_NOCODEC_ZEPHYR&testcase=multiple-pipeline-playback looks very much like crash thesofproject/sof/issues/4414 and the failures happening right after it seem to be the fallout. |
Loading modules that are already loaded is pointless. Now it is possible to pass module parameters. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
703e544 to
41ff6ef
Compare
Loading modules that are already loaded is pointless.
Now it is possible to pass module parameters.
Signed-off-by: Marc Herbert marc.herbert@intel.com