Skip to content

[SKIP CI] sof_insert.sh: add support for module parameters #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marc-hb merged 1 commit into from
Jul 13, 2021
Merged

[SKIP CI] sof_insert.sh: add support for module parameters #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions tools/kmod/sof_insert.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,29 @@

insert_module() {

local MODULE="$1"
local MODULE="$1"; shift

@fredoh9 fredoh9 Jul 8, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shift? is this required?

@marc-hb marc-hb Jul 8, 2021

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes to remove the module name from "$@" below


if modinfo "$MODULE" &> /dev/null ; then
printf 'MODPROBE\t%s\n' "$MODULE"
sudo modprobe "$MODULE"
printf 'MODPROBE\t%s\t\t' "$MODULE"
printf '%s ' "$@"
printf '\n'
sudo modprobe "$MODULE" "$@"
else
printf 'SKIP \t%s \tnot in tree\n' "$MODULE"
printf 'SKIP \t%s \t(not in tree)\n' "$MODULE"
fi
}

# Test sudo first, not after dozens of SKIP
sudo true


# This is not required unless you want to change the default flags.
# For the list of flags search: git -C linux grep SOF_DBG_
# Warning: the DMA trace can be forced ON in Kconfig and
# the SOF_DBG_ENABLE_TRACE bit ignored here.
# insert_module snd_sof sof_debug=1

@plbossart plbossart Jul 8, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed? We can already add module parameters in /etc/modprobe.d/alsa-base.conf



# Insert codec drivers first, they are required to register ASoC components

insert_module snd_soc_da7213
Expand Down