Repository navigation
Conversation
xiulipan
suggested changes
Dec 18, 2019
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Some simple questions inline.
| # now output current process with tail command | ||
| clear | ||
| tail -f $STRESS_OUTPUT_LOG | ||
| # TODO: need to verify with S3 status to confirm script block |
|
|
||
| touch $STRESS_OUTPUT_LOG | ||
| touch $STRESS_STATUS_LOG | ||
| [ ! -f $LOG_ROOT/cmd-orig.txt ] && cp $LOG_ROOT/cmd.txt $LOG_ROOT/cmd-orig.txt |
Contributor
There was a problem hiding this comment.
It may good to add some comments here to explain why cp is needed here.
| func_lib_trigger_stress() | ||
| { | ||
| export LOG_ROOT=$LOG_ROOT | ||
| STRESS_OUTPUT_LOG="$LOG_ROOT/stress.txt" |
Contributor
There was a problem hiding this comment.
Can we have some iteration index here in the log files? Or this will contain full round stress test logs?
Contributor
Author
There was a problem hiding this comment.
because it have different stress type
So here I write for the reboot case, it will trigger this function after each time system reboot
But from the S3, I think this type case just to trigger this function once
So maybe add status control function in it?
case/lib.sh to add func_lib_trigger_stress which detect current script run from local/remote to keep script can run finish when lost the remote connect Signed-off-by: Wu, BinX <binx.wu@intel.com>
Contributor
Author
|
This change is not the requirement with case design, so close it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
case/lib.sh to add func_lib_trigger_stress
which detect current script run from local/remote
to keep script can run finish when lost the remote connect
Signed-off-by: Wu, BinX binx.wu@intel.com