Skip to content

verify-sof-firmware-load: add --no-pager option to journalctl - #419

Merged
fredoh9 merged 1 commit into
thesofproject:masterfrom
marc-hb:journalctl-nopager
Oct 9, 2020
Merged

fredoh9 merged 1 commit into
thesofproject:masterfrom
marc-hb:journalctl-nopager

Conversation

@marc-hb

@marc-hb marc-hb commented Oct 9, 2020

Copy link
Copy Markdown
Collaborator

Useful when running from a terminal.

Signed-off-by: Marc Herbert marc.herbert@intel.com

Useful when running from a terminal.

Also fix minor but single shellcheck warning added by commit
de70e97

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
marc-hb force-pushed the journalctl-nopager branch from c907a9b to fc7abc8 Compare October 9, 2020 19:32
@marc-hb
marc-hb marked this pull request as ready for review October 9, 2020 19:59
@marc-hb
marc-hb requested a review from a team as a code owner October 9, 2020 19:59

@fredoh9 fredoh9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fredoh9
fredoh9 merged commit 3e73c04 into thesofproject:master Oct 9, 2020
@mengdonglin

mengdonglin commented Oct 10, 2020 •

Copy link
Copy Markdown
Contributor

The fake failure of verify-sof-firmware-load.sh on JSL RVP (internal issue 556) is no longer reproduced in daily test report 519. Thank you, @marc-hb !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants