Skip to content

Feature: add env PATH into hijack sudo function #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiulipan merged 1 commit into from
Jan 2, 2020
Merged

Feature: add env PATH into hijack sudo function #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions case-lib/hijack.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ sudo()
return $?
;;
'1') # sudo without passwd
eval $(echo "$SUDO_CMD $*")
eval $(echo "$SUDO_CMD env 'PATH=$PATH' $*")
return $?
;;
'2') # sudo need passwd
eval $(echo "echo '$SUDO_PASSWD' | $SUDO_CMD -S $*")
eval $(echo "echo '$SUDO_PASSWD' | $SUDO_CMD -S env 'PATH=$PATH' $*")
Comment thread
Bin-QA marked this conversation as resolved.
Resolved
return $?
;;
*) # without sudo permission
Expand Down
4 changes: 2 additions & 2 deletions test-case/check-kmod-load-unload.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ do
func_lib_setup_kernel_last_line

dlogi "run kmod/sof-kmod-remove.sh"
sudo env "PATH=$PATH" sof_remove.sh
sudo sof_remove.sh
[[ $? -ne 0 ]] && dloge "remove modules error" && exit 1

## - 1a: check for errors after removal
Expand All @@ -63,7 +63,7 @@ do

func_lib_setup_kernel_last_line
dlogi "run kmod/sof_insert.sh"
sudo env "PATH=$PATH" sof_insert.sh
sudo sof_insert.sh
[[ $? -ne 0 ]] && dloge "insert modules error" && exit
sleep 1

Expand Down