Repository navigation
hijack.sh: switch first attempt to stop the logger from -INT to -TERM - #382
Merged
Merged
Conversation
Commit 61271a3 ("logger: stop discarding all error messages and fix the cleanup code") made two mistakes: 1. It used the -INT signal which doesn't always work. This broke most tests. 2. It then misused exit_failure=2 where 2 means Not Applicable. This turned most broken tests to green. Rushed commit a2669ff ("hijack.sh: don't fail yet when sof-logger resists kill -INT") then downgraded all this to warning to get the tests passing again. However it didn't deal with the real issue: stopping the logger on the first try. Switching to TERM does it and will hopefully close https://github.com/thesofproject/sof/issues/3433 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
September 18, 2020 04:27
marc-hb
marked this pull request as draft
September 18, 2020 04:28
Collaborator
Author
|
CI results look good so this PR looks ready to me but I'm |
marc-hb
marked this pull request as ready for review
September 18, 2020 16:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 61271a3 ("logger: stop discarding all error messages and fix
the cleanup code") made two mistakes:
tests.
turned most broken tests to green.
Rushed commit a2669ff ("hijack.sh: don't fail yet when sof-logger
resists kill -INT") then downgraded all this to warning to get the tests
passing again. However it didn't deal with the real issue: stopping the
logger on the first try. Switching to TERM does it and will hopefully
close https://github.com/thesofproject/sof/issues/3433
Signed-off-by: Marc Herbert marc.herbert@intel.com