Repository navigation
wavetool.py: clarify cmd_args. No functional change. - #334
Merged
Merged
Conversation
The output of argparse was disguised with two steps: - it was converted to (slightly more verbose) dictionary for no particular reason - that dictionary was passed entirely as is as kwargs to every function, looking like these functions could be called with changing parameters. Remove these two steps and make it clear that these values are always the same global constants. No other change; no functional change. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
aiChaoSONG
approved these changes
Aug 13, 2020
aiChaoSONG
left a comment
aiChaoSONG
left a comment
There was a problem hiding this comment.
Let's use the global cmd line parameters, rather than pass through it to every function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The output of argparse was disguised with two steps:
it was converted to (slightly more verbose) dictionary for no
particular reason
that dictionary was passed entirely as is as kwargs to every function,
looking like these functions could be called with changing parameters.
Remove these two steps and make it clear that these values are always
the same global constants.
No other change; no functional change.
Signed-off-by: Marc Herbert marc.herbert@intel.com