Repository navigation
Bugfix: tools/sof-boot-once.sh builtin & relative path - #3
Merged
Merged
Conversation
xiulipan
suggested changes
Dec 18, 2019
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Can you be more specific about why these two changes is needed? I do not understand why and what change is actually made in the script.
Contributor
Author
commit of this patch already updated |
builtin for fix typo from `${}` to `$()`
`${}` is use for variable, `$()` is catch for output value
here using this for confirm command type
if it is builtin command for bash, so it can direct use it
without to create the full command path for it
relative path to add folder without start with '.'
older script just focus on
'./relative path/script' or '/absolute path/script' style script command
So add this style script command
'relative path/script' support in relative path check
Signed-off-by: Wu, BinX <binx.wu@intel.com>
paulstelian97
approved these changes
Dec 18, 2019
xiulipan
approved these changes
Dec 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builtin for fix typo
relative path to add folder without start with '.'
Signed-off-by: Wu, BinX binx.wu@intel.com