Repository navigation
tools: pipeline filtering enhancement - #269
Merged
Merged
Conversation
Author
|
@keyonjie @ClarexZhou Please give it a try, let me know if there is any issue. |
aiChaoSONG
changed the title
aiChaoSONG
force-pushed
the
pipeline_filter
branch
from
June 30, 2020 10:44
e3e9332 to
0790cc7
Compare
marc-hb
removed their request for review
June 30, 2020 19:06
aiChaoSONG
changed the title
aiChaoSONG
force-pushed
the
pipeline_filter
branch
2 times, most recently
from
July 1, 2020 06:35
21e2fb6 to
7faab35
Compare
Previously, we regard a pipeline as a linked list, and search on widget connets to multiple widgets or connetced by multiple widgets is ignored. This patch enables search on complex widget graph. Signed-off-by: Amery Song <chao.song@intel.com>
added 4 commits
July 2, 2020 10:01
Previously, DMIC16k pipeline is blocked, and no test
case will run on it, because it tends to be used for
keyword detection, and test cases cannot handle it.
This patch adds support for KWD pipeline filtering,
thus enables test on DMIC16k pipeline which is not
used for keyword detection.
Default KWD pipeline is hidden from other pipelines,
to acquire KWD pipeline, run:
sof-tplgreader.py -f "kwd" tplg-path
Signed-off-by: Amery Song <chao.song@intel.com>
Previously, if we want to attach component info to a pipeline, we need duplicated code for each component, eg, PGA and EQ. This patch adds a general function to attach component info to pipeline, thus reduces duplicated code. Signed-off-by: Amery Song <chao.song@intel.com>
Signed-off-by: Amery Song <chao.song@intel.com>
For most DAPM widgets, their names are stored in widgets' name field, and sname field is left empty. It's useless to always do match check on empty string. If a PCM's widget sname contains componnet special keyword, for example, in topology sof-apl-asrc-pcm512x.tplg, PCM's sname is "ASRC ...", we will get a wrong widget to search with "ASRC". Signed-off-by: Amery Song <chao.song@intel.com>
aiChaoSONG
force-pushed
the
pipeline_filter
branch
from
July 2, 2020 02:03
7faab35 to
84b009b
Compare
Signed-off-by: Amery Song <chao.song@intel.com>
keyonjie
approved these changes
Jul 2, 2020
keyonjie
left a comment
keyonjie
left a comment
There was a problem hiding this comment.
Looks good, this will be 1st subtask of the #270. Thanks @aiChaoSONG
ClarexZhou
approved these changes
Jul 2, 2020
ClarexZhou
left a comment
ClarexZhou
left a comment
Contributor
There was a problem hiding this comment.
Verified all works and no side effect
aiChaoSONG
pushed a commit
to aiChaoSONG/sof-test
that referenced
this pull request
Jul 6, 2020
Previously, DMIC16k pipeline acts as KWD pipeline, and it cannot be seperated from other normal capture pipelines, so its test is ignored. After a enhancement in sof-tplgreader.py, we can easily seperate DMIC16k from ohter pipelines. So don't need to ignore its test any more. Enhancement PR: thesofproject#269 Signed-off-by: Amery Song <chao.song@intel.com>
aiChaoSONG
pushed a commit
to aiChaoSONG/sof-test
that referenced
this pull request
Jul 6, 2020
Previously, DMIC16k pipeline acts as KWD pipeline, and it cannot be seperated from other normal capture pipelines, so DMIC16k pipeline is not tested, even it doens't act as KWD pipeline on some platforms. After a enhancement in sof-tplgreader.py, we can easily seperate KWD pipeline from ohter pipelines. So don't need to ignore DMIC16k test any more. Enhancement PR: thesofproject#269 Signed-off-by: Amery Song <chao.song@intel.com>
aiChaoSONG
pushed a commit
to aiChaoSONG/sof-test
that referenced
this pull request
Jul 6, 2020
DMIC16k pipeline mostly acts as KWD pipeline, and it cannot be seperated from other normal capture pipelines, so DMIC16k pipeline is not tested, even it doens't act as KWD pipeline on some platforms. After a enhancement in sof-tplgreader.py, we can easily seperate KWD pipeline from ohter pipelines. So don't need to ignore DMIC16k test any more. Enhancement PR: thesofproject#269 Signed-off-by: Amery Song <chao.song@intel.com>
aiChaoSONG
pushed a commit
to aiChaoSONG/sof-test
that referenced
this pull request
Jul 7, 2020
DMIC16k pipeline mostly acts as KWD pipeline, and it cannot be seperated from other normal capture pipelines, so DMIC16k pipeline is not tested, even it doens't act as KWD pipeline on some platforms. After a enhancement in sof-tplgreader.py, we can easily seperate KWD pipeline from ohter pipelines. So don't need to ignore DMIC16k test any more. PR which block DMIC16k: thesofproject#74 Enhancement PR: thesofproject#269 Signed-off-by: Amery Song <chao.song@intel.com>
aiChaoSONG
pushed a commit
to aiChaoSONG/sof-test
that referenced
this pull request
Jul 7, 2020
DMIC16k pipeline mostly acts as KWD pipeline, and it cannot be seperated from other normal capture pipelines, so DMIC16k pipeline is not tested, even it doens't act as KWD pipeline on some platforms. After a enhancement in sof-tplgreader.py, we can easily seperate KWD pipeline from ohter pipelines. So don't need to ignore DMIC16k test any more. DMIC16k blocked by: thesofproject#74 Pipeline filter enhanced by: thesofproject#269 Signed-off-by: Amery Song <chao.song@intel.com>
aiChaoSONG
pushed a commit
that referenced
this pull request
Jul 27, 2020
DMIC16k pipeline mostly acts as KWD pipeline, and it cannot be seperated from other normal capture pipelines, so DMIC16k pipeline is not tested, even it doens't act as KWD pipeline on some platforms. After a enhancement in sof-tplgreader.py, we can easily seperate KWD pipeline from ohter pipelines. So don't need to ignore DMIC16k test any more. DMIC16k blocked by: #74 Pipeline filter enhanced by: #269 Signed-off-by: Amery Song <chao.song@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage:
sof-tplgreader.py -f "kpbm" tplg-namesof-tplgreader.py tplg-nameorsof-tplgreader.py -f "type:any" tplg-namesof-tplgreader.py -f "eq" tplg-nameorsof-tplgreader.py -f "eq:any" tplg-namesof-tplgreader.py -f "type:playback" tplg-namesof-tplgreader.py -f "type:capture" tplg-nameKWD pipeline is hidden, current test case cannot handle it.sof-tplgreader.py -f "~eq" tplg-namesof-tplgreader.py -f "pga & ~eq" tplg-namesof-tplgreader.py -f "pga | eq" tplg-name