Repository navigation
Card name - #2
Merged
Merged
Conversation
Sometimes card short name has blank space inside it. This will cause sof-dump-status.py get the wrong short name. This patch uses ' - ' as the splitter. This patch requires the card short name doesn't include ' - '. Signed-off-by: Libin Yang <libin.yang@linux.intel.com>
This patch adds the card long name dump support. Signed-off-by: Libin Yang <libin.yang@linux.intel.com>
xiulipan
suggested changes
Dec 16, 2019
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Please help to provide example and clarify if alsalib version need to be check before checking the longname.
Bin-QA
reviewed
Dec 16, 2019
Bin-QA
left a comment
Bin-QA
left a comment
Contributor
There was a problem hiding this comment.
I can accept long name, but I couldn't understand why need to use ' - ' instead ' '
Contributor
Author
|
checked. It is longname. You can refer sound/core/init.c for details. |
Contributor
@Bin-QA Please re-check and approval if you think this PR is OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patchset does: