Repository navigation
test-case: add firmware load subtest for kmod test - #172
Merged
Merged
Conversation
Author
|
check thesofproject/linux#1980 and Kai's email for more info. |
xiulipan
previously requested changes
Apr 8, 2020
xiulipan
left a comment
xiulipan
left a comment
Contributor
There was a problem hiding this comment.
Good point to grep with shared keyword, but need to avoid debug info.
Author
Contributor
|
@aiChaoSONG I'm not sure the kmod reload logic, how about this part replace by sub-case: verify-sof-firmware-load.sh |
Author
@Bin-QA Genius, the check I have done in the PR is also in verify-sof-firmware-load.sh, and this script also checked firmware info. this is a perfect solution. |
As the kernel has made its log less verbose, the key word 'firmware boot complete' we use is not in the less verbose log now. So remove the check of this keyword. Instead, add verify-sof-firmware-load.sh subtest to check if firmware is loaded successfully after module insertion. Signed-off-by: Amery Song <chao.song@intel.com>
aiChaoSONG
changed the title
libinyang
reviewed
Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the kernel has made its log less verbose, the key
word 'firmware boot complete' we use is not in the
less verbose log now. So remove the check of this
keyword.
Instead, add verify-sof-firmware-load.sh subtest
to check if firmware is loaded successfully after
module insertion.
tested on mantis, glk, PASSED