Repository navigation
verify-kernel-boot-log.sh: fix missing boot logs on failure - #1191
Merged
Merged
Conversation
Provide a new, boot_logs.txt file no matter what happens. Note that file now includes user-space logs, not just kernel logs. Also: fix bug where script times out and does not run when the SOF firmware is not loaded: no need to define NO_POLL_FW_LOADING anymore. The trick is to stop calling `start_test()`. verify-kernel-boot-log.sh is not an audio test! Fixes sof-test issues thesofproject#1036 and thesofproject#1112, find more details there. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
May 8, 2024 23:42
This was referenced May 8, 2024
Collaborator
Author
|
Wow, ALL hardware tests are 100% green! The new |
fredoh9
reviewed
May 9, 2024
| { | ||
| local exit_code=$1 | ||
|
|
||
| journalctl --boot > "$LOG_ROOT"/boot_log.txt |
Contributor
There was a problem hiding this comment.
Normally I don't pay attention to user space log at boot. What can we expect more clues from user space log?
Collaborator
Author
There was a problem hiding this comment.
What can we expect more clues from user space log?
- Sound daemons errors (pulseaudio, pipewire,...)
- Display / auto-login issues: Ubuntu 22: Wayland aborts without a connected monitor. No hotplug either + Xorg weird crash #964, Ubuntu22: GDM does not report missing GPU -> use reliable lightdm instead? #998
- Anything else that could give clues.
If you look at some examples, you'll see the added volume is low compared to SOF debug logs. One example on a fresh boot:
root@jf-lnlm-rvp-nocodec-3:~# journalctl -k | wc -l
1857
root@jf-lnlm-rvp-nocodec-3:~# journalctl -b | wc -l
2313
Collaborator
Author
There was a problem hiding this comment.
A couple more after looking at diff -u <(journalctl -k) <(journalctl -b) | less
- Network initialization
- NTP init
- sensors stuff (thermal)
- other systemd logs
fredoh9
approved these changes
May 9, 2024
fredoh9
left a comment
fredoh9
left a comment
Contributor
There was a problem hiding this comment.
Beauty of trap! Looks good.
Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a new, boot_logs.txt file no matter what happens. Note that file now includes user-space logs, not just kernel logs.
Also: fix bug where script times out and does not run when the SOF
firmware is not loaded: no need to define NO_POLL_FW_LOADING anymore.
The trick is to stop calling
start_test(). verify-kernel-boot-log.sh is not an audio test!Fixes sof-test issues #1036 and #1112, find more details there.