Repository navigation
lib.sh: catch some mtrace-reader failures to start thanks to "OSError" - #1183
Merged
Merged
Conversation
This makes tests fail at the end when mtrace-reader.py could be started,
for instance because one is already running (see example below)
Reminder: you can use -s to ignore firmware logs.
Traceback (most recent call last):
File "mtrace-reader.py", line 20, in <module>
fd = os.open(MTRACE_FILE, os.O_RDONLY)
OSError: [Errno 16] Device or resource busy: '/sys/kernel/debug/sof/mtrace/core0'
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
Unrelated sof-logger issue in https://sof-ci.01.org/softestpr/PR1183/build360/devicetest/index.html Everything 100% green. |
kv2019i
approved these changes
Apr 29, 2024
kv2019i
left a comment
kv2019i
left a comment
Contributor
There was a problem hiding this comment.
Typo in commit message "could be started" -> "could not be started" ? .
But patch obvious enough.
Collaborator
Author
|
Thanks for the review! And for catching the typo. I would have pushed a fix for the commit title but I don't think it's worth it for one sentence in the commit message body; the risk of confusion seems low enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes tests fail at the end when mtrace-reader.py could be started, for instance because one is already running (see example below)
Reminder: you can use -s to ignore firmware logs.