Skip to content

sof-kernel-log-check.sh: ignore unrelated ACPI error on LNL platform - #1124

Merged
marc-hb merged 1 commit into
thesofproject:mainfrom
keqiaozhang:lnl_filter
Nov 1, 2023
Merged

marc-hb merged 1 commit into
thesofproject:mainfrom
keqiaozhang:lnl_filter

Conversation

@keqiaozhang

Copy link
Copy Markdown
Contributor

No description provided.

@keqiaozhang
keqiaozhang requested a review from a team as a code owner October 31, 2023 15:08
plbossart
plbossart previously approved these changes Oct 31, 2023
Comment thread tools/sof-kernel-log-check.sh Outdated
ignore_str="$ignore_str"'|mei_me 0000:00:16\..\: .+'

# ignore the ACPI error on LNL.
ignore_str="$ignore_str""|kernel: ACPI: \\\\: Can't tag data node"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any idea what this error means? We do use ACPI. If yes please add a comment. Is it safe to ignore across all products? If not there is a lnl platform section below.

@keqiaozhang keqiaozhang Nov 1, 2023 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The errors come from https://github.com/thesofproject/linux/blob/bf67942088295fc31042c8d8d71a212c53a9134c/drivers/acpi/property.c#L366C1-L386C2.
It means that data nodes failed to tie to ACPI handles. I don't know much about this, but from my perspective it's harmless to audio.
[Edit]: I have updated this PR.

This error means that data nodes failed to tie to ACPI handles.
But no audio impact, it's safe to ignore it on LNL.

Signed-off-by: Keqiao Zhang <keqiao.zhang@intel.com>
@marc-hb
marc-hb merged commit 6db43a1 into thesofproject:main Nov 1, 2023
@marc-hb

marc-hb commented Nov 1, 2023

Copy link
Copy Markdown
Collaborator

@keqiaozhang any idea why jenkins did not pick that up?

@keqiaozhang

keqiaozhang commented Nov 6, 2023 •

Copy link
Copy Markdown
Contributor Author

@keqiaozhang any idea why jenkins did not pick that up?

It seems that Jenkins failed to post the status to GitHub, I filed internal bug 525 to track it. I spent hours on it, but no clues so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants