Repository navigation
Shellcheck check xrun injection - #1058
Merged
marc-hb merged 2 commits intoJun 26, 2023
Merged
Conversation
The previous source reference for lib.sh triggers shellcheck errors. Added quotes to all shellcheck suggested lines. Signed-off-by: Greg Galloway <greg.galloway@intel.com>
SC2233 (style): Remove superfluous (..) around condition to avoid subshell overhead. SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. SC2219 (style): Instead of 'let expr', prefer (( expr )) . Signed-off-by: Greg Galloway <greg.galloway@intel.com>
marc-hb
approved these changes
Jun 14, 2023
Collaborator
|
No test has been run yet after 1h, this is not normal: 
|
Contributor
Author
|
SOFCI TEST Saw a strange issue with the previous "sof_test_pr" Jenkins run: |
Contributor
Author
|
I should have looked more closely. It ends up check-xrun-injection.sh isn't called as part of the daily or PR tests, it's only part of run-all-tests. |
Contributor
Author
|
Test failures are unrelated, this test doesn't run during PR testing. |
Collaborator
So you gave it a decent round of testing locally, correct? |
Contributor
Author
With pretty much every little change I made. |
Collaborator
|
Thanks! Let's merge this first thing on Monday |
marc-hb
approved these changes
Jun 26, 2023
| sof-process-state.sh "$pid" >/dev/null || { | ||
| dloge "aplay/arecord process is in an abnormal status" | ||
| kill -9 $pid && wait $pid 2>/dev/null | ||
| kill -9 "$pid" && wait "$pid" 2>/dev/null |
Collaborator
There was a problem hiding this comment.
This code seems incompatible with set -e but - off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various shellcheck quoting issues and other fixes.
Signed-off-by: Greg Galloway greg.galloway@intel.com