Repository navigation
test-case: add verify-ucm-config.sh - #1
Conversation
xiulipan
left a comment
xiulipan
left a comment
There was a problem hiding this comment.
This key part for this case is for the verbs. I feel almost lost in understand why the process is needed to handle the verbs can you provide some example to help us understand? Maybe add some explanation in the header and show them with -h is a good idea.
| ((i=0)) | ||
| fi | ||
| done | ||
| IFS="$OLD_IFS" |
There was a problem hiding this comment.
What is this line used for? restore the IFS before exit?
|
It seems the alsaucm test case is not so easy to understand (it's a totally new case for us all). I will try to add as more comments as possible to help others to review the code easily. |
This patch add the case of verifying the ucm configuration files. This patch doesn't support UCMv2. And UCMv2 verifying patch will be submitted after DUT has supported UCMv2. Signed-off-by: Libin Yang <libin.yang@linux.intel.com>
|
patch updated |
|
ping @xiulipan |
xiulipan
left a comment
xiulipan
left a comment
There was a problem hiding this comment.
LGTM, I read the comments and finally got a simple idea about how UCM is taking effect.
|
ping for merge |
|
@Bin-QA @keqiaozhang @aiChaoSONG Please help to give a second approval. |
|
ping for merge |
This patch add the case of verifying the ucm configuration files.
This patch doesn't support UCMv2. And UCMv2 verifying patch will be
submitted after DUT has supported UCMv2.
Signed-off-by: Libin Yang libin.yang@linux.intel.com