Skip to content

kmod-load-unload shouldn't exit with modules unloaded #351

Closed

Description

@lyakh

If an error is detected when unloading kernel modules (see e.g. thesofproject/linux#2334) the check-kmod-load-unload.sh script exits immediately with modules unloaded, so no further testing is possible. If a proposed policy is implemented where the tested system is rebooted after a failure, this would be fixed. Otherwise an attempt should be made to re-load the modules after the error.

Activity

  1. added a commit that references this issue on Sep 1, 2020
    e2361bf
  2. marc-hb commented on Sep 8, 2020

    @marc-hb
    Collaborator

    In thesofproject/linux#2334 @plbossart suggested we try multiple times and count the number of errors.

    I looked at the code it should be doable but please first please help review the simple shellcheck cleanup in #368

  3. aiChaoSONG commented on Jun 21, 2021

    @aiChaoSONG

    It is not easy to fix it in the script, because kmod test touched kernel, and it is hard to make sure the kernel module can be reloaded properly, and the HW status is status, so current solution is 'when kmod test falied, we will reboot and continue test'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:bugSomething doesn't work as expectedtype:enhancementNew framework feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions